Need help getting this shader to run

[rockybalboba]

Hello, I'm trying to get this shader to run but I keep getting errors. The shader works on other engines like psych and codename but I can't get it to work here, if it can

I tried to make a module thingy to test it before making it level or song specific, this is what I did:

import flixel.FlxG;
import funkin.modding.module.Module;
import funkin.Paths;
import funkin.play.PlayState;
import flixel.FlxCamera;
import flixel.addons.display.FlxRuntimeShader;
import openfl.filters.ShaderFilter;
import StringTools;

class NtscFilter extends Module {

	var crtShader:FlxRuntimeShader = new FlxRuntimeShader(Assets.getText(Paths.frag('ntsc')));
	
	public function new()
	{	
		super('NtscFilter');
	}

	public override function onCountdownStart(event:ScriptEvent) {
		super.onCountdownStart(event);
		
        PlayState.instance.camGame.filters = [new ShaderFilter(crtShader)];
			
	}
}

and this is the error that pops up when I try running a song with it:

---------------------------
Error
---------------------------
[openfl.display.Shader] ERROR: Error compiling fragment shader
0(106) : error C7516: OpenGL does not allow constant arrays
0(114) : error C7553: OpenGL array assignments require #version 120
0(116) : error C7516: OpenGL does not allow constant arrays
0(124) : error C7553: OpenGL array assignments require #version 120

#version 100

      

				#ifdef GL_ES

				#ifdef GL_FRAGMENT_PRECISION_HIGH

					precision highp float;

				#else

					precision mediump float;

				#endif

				#endif

		varying vec4 openfl_ColorMultiplierv;

		varying vec4 openfl_ColorOffsetv;

		varying vec2 openfl_TextureCoordv;



		uniform bool openfl_HasColorTransform;

		uniform vec2 openfl_TextureSize;

		uniform sampler2D bitmap;


		uniform bool hasTransform;  // TODO: Is this still needed? Apparently, yes!

		uniform bool hasColorTransform;

		vec4 flixel_texture2D(sampler2D bitmap, vec2 coord)

		{

			vec4 color = texture2D(bitmap, coord);

			if (!(hasTransform || openfl_HasColorTransform))

				return color;

			

			if (color.a == 0.0)

				return vec4(0.0, 0.0, 0.0, 0.0);

			

			if (openfl_HasColorTransform || hasColorTransform)

			{

				color = vec4 (color.rgb / color.a, color.a);

				vec4 mult = vec4 (openfl_ColorMultiplierv.rgb, 1.0);

				color = clamp (openfl_ColorOffsetv + (color * mult), 0.0, 1.0);

				

				if (color.a == 0.0)

					return vec4 (0.0, 0.0, 0.0, 0.0);

				

				return vec4 (color.rgb * color.a * openfl_Alphav, color.a * openfl_Alphav);

			}

			

			return color * openfl_Alphav;

		}

	


#pragma format R8G8B8A8_SRGB

#define NTSC_CRT_GAMMA 2.5
#define NTSC_MONITOR_GAMMA 2.0

#define TWO_PHASE
#define COMPOSITE
//#define THREE_PHASE
//#define SVIDEO

#define PI 3.14159265

#if defined(TWO_PHASE)
    #define CHROMA_MOD_FREQ (4.0 * PI / 15.0)
#elif defined(THREE_PHASE)
    #define CHROMA_MOD_FREQ (PI / 3.0)
#endif

#if defined(COMPOSITE)
    #define SATURATION 1.0
    #define BRIGHTNESS 1.0
    #define ARTIFACTING 1.0
    #define FRINGING 1.0
#elif defined(SVIDEO)
    #define SATURATION 1.0
    #define BRIGHTNESS 1.0
    #define ARTIFACTING 0.0
    #define FRINGING 0.0
#endif

uniform int uFrame;
uniform float uInterlace;

#if defined(COMPOSITE) || defined(SVIDEO)
mat3 mix_mat = mat3(
    BRIGHTNESS, FRINGING, FRINGING,
    ARTIFACTING, 2.0 * SATURATION, 0.0,
    ARTIFACTING, 0.0, 2.0 * SATURATION
);
#endif

const mat3 yiq2rgb_mat = mat3(
    1.0, 0.956, 0.621,
    1.0, -0.272, -0.6474,
    1.0, -1.106, 1.7046
);

vec3 yiq2rgb(vec3 y) { return y * yiq2rgb_mat; }

const mat3 yiq_mat = mat3(
    0.2989, 0.587, 0.114,
    0.5959, -0.2744, -0.3216,
    0.2115, -0.5229, 0.3114
);

vec3 rgb2yiq(vec3 c) { return c * yiq_mat; }

#define TAPS 32
const float luma_filter[TAPS + 1] = float[TAPS + 1](
    -0.000174844, -0.000205844, -0.000149453, -0.000051693, 0.000000000,
    -0.000066171, -0.000245058, -0.000432928, -0.000472644, -0.000252236,
    0.000198929, 0.000687058, 0.000944112, 0.000803467, 0.000363199,
    0.000013422, 0.000253402, 0.001339461, 0.002932972, 0.003983485,
    0.003026683, -0.001102056, -0.008373026, -0.016897700, -0.022914480,
    -0.021642347, -0.008863273, 0.017271957, 0.054921920, 0.098342579,
    0.139044281, 0.168055832, 0.178571429
);

const float chroma_filter[TAPS + 1] = float[TAPS + 1](
    0.001384762, 0.001678312, 0.002021715, 0.002420562, 0.002880460,
    0.003406879, 0.004004985, 0.004679445, 0.005434218, 0.006272332,
    0.007195654, 0.008204665, 0.009298238, 0.010473450, 0.011725413,
    0.013047155, 0.014429548, 0.015861306, 0.017329037, 0.018817382,
    0.020309220, 0.021785952, 0.023227857, 0.024614500, 0.025925203,
    0.027139546, 0.028237893, 0.029201910, 0.030015081, 0.030663170,
    0.031134640, 0.031420995, 0.031517031
);

vec4 pass1(vec2 uv) {
    vec2 fragCoord = uv * openfl_TextureSize;
    vec4 c = texture2D(bitmap, uv);
    vec3 y = rgb2yiq(c.rgb);
    float p = 0.0;
    #if defined(TWO_PHASE)
        p = PI * (mod(fragCoord.y, 2.0) + float(uFrame));
    #elif defined(THREE_PHASE)
        p = 0.6667 * PI * (mod(fragCoord.y, 3.0) + float(uFrame));
    #endif
    float m = p + fragCoord.x * CHROMA_MOD_FREQ;
    vec2 mod = vec2(cos(m), sin(m));
    if (uInterlace == 1.0) {
        y.yz *= mod;
        y = mix_mat * y;
        y.yz *= mod;
    }
    return vec4(y, c.a);
}

vec4 get_offset(vec2 uv, float o, float x) { return pass1(uv + vec2((o - 0.5) * x, 0.0)); }

void main() {
    vec2 uv = openfl_TextureCoordv;
    vec2 fragCoord = uv * openfl_TextureSize;
    float one_x = 1.0 / openfl_TextureSize.x;
    vec4 signal = vec4(0.0);
    for (int i = 0; i < TAPS; i++) {
        float o = float(i);
        vec4 s = get_offset(uv, o - float(TAPS), one_x) * 2.0;
        signal += s * vec4(luma_filter[i], chroma_filter[i], chroma_filter[i], 1.0);
    }
    signal += pass1(uv - vec2(0.5 * one_x, 0.0)) * vec4(luma_filter[TAPS], chroma_filter[TAPS], chroma_filter[TAPS], 1.0);
    vec3 rgb = yiq2rgb(signal.xyz);
    gl_FragColor = vec4(pow(rgb, vec3(NTSC_CRT_GAMMA / NTSC_MONITOR_GAMMA)), texture2D(bitmap, uv).a);
}
---------------------------
OK   
---------------------------

Any help would be appreciated, thanks.

[Lasercar]

Use a higher version?

[rockybalboba]

adding that bit at the end didn't seem to do anything, I still get the same error as before

[NotHyper-474]

adding that bit at the end didn't seem to do anything, I still get the same error as before

Maybe posting the shader code here would allow us to help you better (the one in the crash log was modified by Flixel to run with OpenFL)

[rockybalboba]

Oh right, I didn't notice it was modified in the report, here it is

#pragma header

#pragma format R8G8B8A8_SRGB

#define NTSC_CRT_GAMMA 2.5
#define NTSC_MONITOR_GAMMA 2.0

#define TWO_PHASE
#define COMPOSITE
//#define THREE_PHASE
//#define SVIDEO

#define PI 3.14159265

#if defined(TWO_PHASE)
    #define CHROMA_MOD_FREQ (4.0 * PI / 15.0)
#elif defined(THREE_PHASE)
    #define CHROMA_MOD_FREQ (PI / 3.0)
#endif

#if defined(COMPOSITE)
    #define SATURATION 1.0
    #define BRIGHTNESS 1.0
    #define ARTIFACTING 1.0
    #define FRINGING 1.0
#elif defined(SVIDEO)
    #define SATURATION 1.0
    #define BRIGHTNESS 1.0
    #define ARTIFACTING 0.0
    #define FRINGING 0.0
#endif

uniform int uFrame;
uniform float uInterlace;

#if defined(COMPOSITE) || defined(SVIDEO)
mat3 mix_mat = mat3(
    BRIGHTNESS, FRINGING, FRINGING,
    ARTIFACTING, 2.0 * SATURATION, 0.0,
    ARTIFACTING, 0.0, 2.0 * SATURATION
);
#endif

const mat3 yiq2rgb_mat = mat3(
    1.0, 0.956, 0.621,
    1.0, -0.272, -0.6474,
    1.0, -1.106, 1.7046
);

vec3 yiq2rgb(vec3 y) { return y * yiq2rgb_mat; }

const mat3 yiq_mat = mat3(
    0.2989, 0.587, 0.114,
    0.5959, -0.2744, -0.3216,
    0.2115, -0.5229, 0.3114
);

vec3 rgb2yiq(vec3 c) { return c * yiq_mat; }

#define TAPS 32
const float luma_filter[TAPS + 1] = float[TAPS + 1](
    -0.000174844, -0.000205844, -0.000149453, -0.000051693, 0.000000000,
    -0.000066171, -0.000245058, -0.000432928, -0.000472644, -0.000252236,
    0.000198929, 0.000687058, 0.000944112, 0.000803467, 0.000363199,
    0.000013422, 0.000253402, 0.001339461, 0.002932972, 0.003983485,
    0.003026683, -0.001102056, -0.008373026, -0.016897700, -0.022914480,
    -0.021642347, -0.008863273, 0.017271957, 0.054921920, 0.098342579,
    0.139044281, 0.168055832, 0.178571429
);

const float chroma_filter[TAPS + 1] = float[TAPS + 1](
    0.001384762, 0.001678312, 0.002021715, 0.002420562, 0.002880460,
    0.003406879, 0.004004985, 0.004679445, 0.005434218, 0.006272332,
    0.007195654, 0.008204665, 0.009298238, 0.010473450, 0.011725413,
    0.013047155, 0.014429548, 0.015861306, 0.017329037, 0.018817382,
    0.020309220, 0.021785952, 0.023227857, 0.024614500, 0.025925203,
    0.027139546, 0.028237893, 0.029201910, 0.030015081, 0.030663170,
    0.031134640, 0.031420995, 0.031517031
);

vec4 pass1(vec2 uv) {
    vec2 fragCoord = uv * openfl_TextureSize;
    vec4 c = texture2D(bitmap, uv);
    vec3 y = rgb2yiq(c.rgb);
    float p = 0.0;
    #if defined(TWO_PHASE)
        p = PI * (mod(fragCoord.y, 2.0) + float(uFrame));
    #elif defined(THREE_PHASE)
        p = 0.6667 * PI * (mod(fragCoord.y, 3.0) + float(uFrame));
    #endif
    float m = p + fragCoord.x * CHROMA_MOD_FREQ;
    vec2 mod = vec2(cos(m), sin(m));
    if (uInterlace == 1.0) {
        y.yz *= mod;
        y = mix_mat * y;
        y.yz *= mod;
    }
    return vec4(y, c.a);
}

vec4 get_offset(vec2 uv, float o, float x) { return pass1(uv + vec2((o - 0.5) * x, 0.0)); }

void main() {
    vec2 uv = openfl_TextureCoordv;
    vec2 fragCoord = uv * openfl_TextureSize;
    float one_x = 1.0 / openfl_TextureSize.x;
    vec4 signal = vec4(0.0);
    for (int i = 0; i < TAPS; i++) {
        float o = float(i);
        vec4 s = get_offset(uv, o - float(TAPS), one_x) * 2.0;
        signal += s * vec4(luma_filter[i], chroma_filter[i], chroma_filter[i], 1.0);
    }
    signal += pass1(uv - vec2(0.5 * one_x, 0.0)) * vec4(luma_filter[TAPS], chroma_filter[TAPS], chroma_filter[TAPS], 1.0);
    vec3 rgb = yiq2rgb(signal.xyz);
    gl_FragColor = vec4(pow(rgb, vec3(NTSC_CRT_GAMMA / NTSC_MONITOR_GAMMA)), texture2D(bitmap, uv).a);
}

[NotHyper-474]

Works fine on my end

Corrected code for reference

import flixel.FlxG;
import funkin.modding.module.Module;
import funkin.Paths;
import funkin.play.PlayState;
import flixel.FlxCamera;
import flixel.addons.display.FlxRuntimeShader;
import openfl.filters.ShaderFilter;
import StringTools;

class NtscFilter extends Module {

	var crtShader:FlxRuntimeShader = new FlxRuntimeShader(Assets.getText(Paths.frag('ntsc')), null, '120');

	public function new()
	{
		super('NtscFilter');
	}

	public override function onCountdownStart(event:ScriptEvent) {
		super.onCountdownStart(event);

        PlayState.instance.camGame.filters = [new ShaderFilter(crtShader)];

	}
}

[rockybalboba]

Jesus christ, I pasted yours and now it works fine and after comparing I was missing a closed parenthesis
tunnel vision I swear to god, thanks a bunch it's all good now

[NotHyper-474]

Looking at the snippet I sent before I realize that was my bad lol whoopsies

But glad to see it's working now!