Skip to content

[BUGFIX?] Fix Playhead Being Outside Grid #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

[BUGFIX?] Fix Playhead Being Outside Grid #5090

merged 1 commit into from
Jun 17, 2025

Conversation

anysad
Copy link
Contributor

@anysad anysad commented May 14, 2025

Description

This PR aims to fix an issue where the playhead going outside the chart editor grid, which lowkey gets on my nerves a bit...

Screenshots/Videos

change

@github-actions github-actions bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. labels May 14, 2025
@NotHyper-474
Copy link
Contributor

Note: Not to be confused with #5024

@Hundrec Hundrec added topic: chart editor Related to the operation of the Chart Editor. size: tiny A tiny pull request with 4 or fewer changes. type: minor bug Involves a minor bug or issue. and removed size: small A small pull request with 10 or fewer changes. labels May 14, 2025
@Hundrec Hundrec self-requested a review May 14, 2025 20:28
Hundrec
Hundrec approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolute Cinema.

TechnikTil
TechnikTil approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you say it... pmo?

GET OUT!!

@anysad
Copy link
Contributor Author

anysad commented May 19, 2025

ts pmo ngl 🥀

@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels May 29, 2025
@EliteMasterEric EliteMasterEric added this to the 0.7.0 milestone May 29, 2025
@AbnormalPoof AbnormalPoof merged commit 456596a into FunkinCrew:develop Jun 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechnikTil TechnikTil TechnikTil approved these changes

@Hundrec Hundrec Hundrec approved these changes

Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: tiny A tiny pull request with 4 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
0.7.0 - Mobile Port
Development

Successfully merging this pull request may close these issues.
6 participants
@anysad @NotHyper-474 @TechnikTil @Hundrec @EliteMasterEric @AbnormalPoof