Skip to content

[BUGFIX] Fix the Playback Speed causing weird behavior during Playtesting #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[BUGFIX] Fix the Playback Speed causing weird behavior during Playtesting #5107

wants to merge 1 commit into from

Conversation

KoloInDaCrib
Copy link
Contributor

Linked Issues

Fixes #4176

Description

This is pretty much a redo of Lasercar's playback speed PR #4182, however he had an issue where the GF characters would sometimes have their necks snap. This PR fixes that issue, on top of fixing playback speed.
I have gotten permission from him to make a PR with the fix, and to be extra safe, I've let him co-author the commit.

Screenshots/Videos

lit.up.but.darnell.has.made.in.heaven.mp4

@KoloInDaCrib @Lasercar
hi lasercar
5ae734a 
Co-Authored-By: Lasercar <[email protected]>
@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. and removed status: pending triage Awaiting review. labels May 17, 2025
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. labels May 17, 2025
@trayfellow
Copy link

Friday Night(core) Funkin'

@Hundrec
Copy link
Member

Hundrec commented May 17, 2025

You win Funkin' GitHub Ranked for today

This was referenced May 17, 2025
Closed
Closed
Lasercar
Lasercar reviewed May 17, 2025
View reviewed changes
Copy link
Contributor

@Lasercar Lasercar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only suggestion would be to add:

@:privateAccess
if ((!FlxG.game._lostFocus && Preferences.autoPause) || !Preferences.autoPause)

To fix #4332 as well.

@Hundrec Hundrec linked an issue Jun 30, 2025 that may be closed by this pull request
Bug Report: Playback speed does some weird (cool) stuff in playtest mode #4176
Open
3 tasks
@Hundrec Hundrec added status: rejected Issue did not pass review or PR cannot be approved. and removed type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. pr: haxe PR modifies game code. labels Jun 30, 2025
@github-actions github-actions bot closed this Jun 30, 2025
@KoloInDaCrib KoloInDaCrib deleted the song-but-fast-yeah branch June 30, 2025 07:40
@Lasercar
Copy link
Contributor

Hundrec wins Funkin' GitHub Ranked for today in the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lasercar Lasercar Lasercar left review comments

Assignees
No one assigned
Labels
size: medium A medium pull request with 100 or fewer changes. status: rejected Issue did not pass review or PR cannot be approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug Report: Playback speed does some weird (cool) stuff in playtest mode
4 participants
@KoloInDaCrib @trayfellow @Hundrec @Lasercar