[MODDING] Add dialogue callbacks for Module
#5140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAASDMGRTHMTHLBFDMVDFLMDV:FLVM:FDLMVD:LFMVD:LFMVD:LVM:DL<F"%$:<:"$#Q<#":<">"!":>":>": Big prizes to be won in Pico (Playable)'s Birthday Extravaganza! Download today!
AbnormalPoof
added
type: minor bug
github-actions
bot
added
pr: haxe
AbnormalPoof
added
type: minor bug
EliteMasterEric
requested changes
May 29, 2025
| /** | ||
| * Called as the dialogue starts, and before the first dialogue text is displayed. | ||
| */ | ||
| public function onDialogueStart(event:DialogueScriptEvent):Void; |
There was a problem hiding this comment.
Pretty sure these don't actually get called unless you use implements IDialogueScriptedClass, can you confirm these script events actually run?
EliteMasterEric
added
status: needs revision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why
Moduledidn't have these. This PR adds them.