Skip to content

[BUGFIX/POLISH?] Fix how HitNoteScriptEvent not being called, because of hitsounds volume #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[BUGFIX/POLISH?] Fix how HitNoteScriptEvent not being called, because of hitsounds volume #5147

wants to merge 1 commit into from

Conversation

PurSnake
Copy link
Contributor

Linked Issues

idk

Changes

Moved HitNoteScriptEvent dispatching OUTSIDE of handleHitsounds

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. labels May 22, 2025
@Hundrec Hundrec added the type: minor bug Involves a minor bug or issue. label May 22, 2025
@Hundrec
Copy link
Member

Hundrec commented May 22, 2025

Can you elaborate on what issue this would fix for the average player?

@PurSnake
Copy link
Contributor Author

ChartEditorState does not dispatches NoteHitEvent when hitsounds both 0 volume.
It reduces the capabilities of scripts.

But now it works regardless of hitsounds volume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PurSnake @Hundrec