Skip to content

[ENHANCEMENT] Stage Editor - New stage keybind + exit hotkey change + Stage Editor/Builder build presets #5175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Lasercar
Copy link
Contributor

@Lasercar Lasercar commented May 30, 2025

Linked Issues

Closes #4811, fixes #4808

Description

Ctrl+N -> new stage dialog

Also adds windows target configuration preset for straight to stage editor (and the stage builder too).

Also also makes the stage editor exit to the main menu, like every other editor.

Also also also changes the exit hotkey to Ctrl + Q (and the text), to match the chart editor.

Screenshots/Videos

2025-05-30.20-24-15.mp4

@Lasercar Lasercar changed the base branch from main to develop May 30, 2025 10:25
@github-actions github-actions bot added pr: haxe PR modifies game code. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels May 30, 2025
@Lasercar Lasercar changed the title [ENHANCEMENT] Stage Editor - New stage keybind [ENHANCEMENT] Stage Editor - New stage keybind + Stage Editor/Builder build presets May 30, 2025
@Hundrec Hundrec added topic: stage editor Related to the operation of the Stage Editor. type: enhancement Involves an enhancement or new feature. labels May 30, 2025
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Lasercar Lasercar force-pushed the enhancement/stage-editor-new-stage-keybind branch from 9876887 to 225da44 Compare June 16, 2025 11:19
@Lasercar Lasercar changed the title [ENHANCEMENT] Stage Editor - New stage keybind + Stage Editor/Builder build presets [ENHANCEMENT] Stage Editor - New stage keybind + exit hotkey change + Stage Editor/Builder build presets Jun 16, 2025
@Lasercar Lasercar requested a review from JVNpixels June 16, 2025 11:23
@Lasercar Lasercar force-pushed the enhancement/stage-editor-new-stage-keybind branch from 225da44 to 5641835 Compare June 16, 2025 11:28
@Lasercar Lasercar changed the base branch from develop to main June 16, 2025 11:30
@Lasercar Lasercar changed the base branch from main to develop June 16, 2025 11:30
Copy link
Contributor

@JVNpixels JVNpixels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM!

@Hundrec Hundrec added status: reviewing internally Under consideration and testing. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. status: reviewing internally Under consideration and testing. labels Jun 17, 2025
@Hundrec Hundrec added this to the 0.7.0 milestone Jun 17, 2025
@Hundrec
Copy link
Member

Hundrec commented Jun 17, 2025

Will merge once conflicts are resolved

Lasercar added 3 commits June 18, 2025 13:05
Also windows target configuration preset for straight to stage editor (not to be confused with the stage builder)
@Lasercar Lasercar force-pushed the enhancement/stage-editor-new-stage-keybind branch from 5641835 to db99cc1 Compare June 18, 2025 03:12
@Hundrec Hundrec merged commit f597a87 into FunkinCrew:develop Jun 18, 2025
2 checks passed
@Lasercar
Copy link
Contributor Author

Woah, what, before I even say I fixed the conflicts??????????????????

@Lasercar Lasercar deleted the enhancement/stage-editor-new-stage-keybind branch June 18, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: stage editor Related to the operation of the Stage Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: CTRL+N Keybind For Stage Editor Bug Report: Stage editor does not exit to the main menu
3 participants