[BUGFIX] Consistent game over camera focus point #6705
+13
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size: medium
Hundrec
added
status: pending triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
None, though LeGooey brought this up earlier today.
Description
The game over menu would focus on the character's mid-point when dying, however it failed to account for the idle animation not playing correctly, which makes the game over menu focus point dependant on the animation that was played before the death sequence started.
This PR fixes it by basing the character middle point to focus on from the pre-established character camera focus point, minus the offsets, since camera focus point position is based on the idle animation of the character.
Screenshots/Videos
Pre-fix:
blud.died.old.mp4
Post-fix:
blud.died.new.mp4