Enable pull-up for GPIO0 (boot/action button) #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@alextrical , can you confirm this issue? Is it ok that the ESP32 and the XMOS have an activated pull-up on the same line? |
gnumpi
force-pushed
the
144-pull-up-for-gpio0
branch
from
cfedb7d to
3df7da2
Compare
Collaborator
Author
|
This should also fix the issue that the action button is not working when the XMOS is not flashed yet. (I assume the default state of the XMOS pin being floating) |
Collaborator
|
Confirmed! This PR enables the action button to complete ESP32 authorization during Nabu onboarding via BLE improv. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the HAT is not connected to the core, the value of the gpio pin for the action/boot button is floating.
When the HAT is connected, the pull-up from the XMOS is used.
This PR enables the internal pull-up for pin 0 on the ESP32-S3.