-
Notifications
You must be signed in to change notification settings - Fork 96
add support for list segments endpoint #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for list segments endpoint #374
Conversation
Consul.Test/OperatorTest.cs
Outdated
| public async Task Segment_List() | ||
| { | ||
| var segments = await _client.Operator.SegmentList(); | ||
| Assert.IsType<string[]>(segments.Response); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could check that the response is not empty (Check if the length of the array is non-zero?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @marcin-krystianc I have made the update
marcin-krystianc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Added support for List segments Endpoint #373