Skip to content

feat(auth): enable multiple auth methods #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 102 commits into
base: main
Choose a base branch
from

Conversation

jescalada
Copy link
Collaborator

@jescalada jescalada commented Feb 16, 2025

This PR enables multiple auth methods and sets the groundwork for adding a JWTStrategy to passport, as mentioned in #1, so we can have an extra security layer for the API.

I opened this PR to keep track of my work. I'll most likely end up closing and reopening it in the Finos repo. Sorry about that!

@jescalada jescalada self-assigned this Feb 16, 2025
@jescalada jescalada changed the title Enable multiple auth methods feat(auth): enable multiple auth methods Mar 10, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 59.09091% with 432 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@83e814b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/proxy/processors/push-action/gitleaks.ts 11.62% 76 Missing ⚠️
src/config/ConfigLoader.ts 62.22% 59 Missing and 9 partials ⚠️
src/proxy/processors/push-action/preReceive.ts 16.32% 41 Missing ⚠️
src/config/index.ts 73.33% 34 Missing and 6 partials ⚠️
src/proxy/index.ts 33.33% 36 Missing and 2 partials ⚠️
src/db/file/repo.ts 50.00% 23 Missing ⚠️
src/service/passport/activeDirectory.js 15.38% 22 Missing ⚠️
src/db/file/pushes.ts 47.05% 18 Missing ⚠️
src/proxy/processors/push-action/parsePush.ts 48.57% 18 Missing ⚠️
src/db/index.ts 42.85% 11 Missing and 5 partials ⚠️
... and 18 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage        ?   49.16%           
=======================================
  Files           ?       52           
  Lines           ?     2103           
  Branches        ?      240           
=======================================
  Hits            ?     1034           
  Misses          ?     1032           
  Partials        ?       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

JamieSlome and others added 30 commits May 19, 2025 06:34
add meeting minutes GitHub Issue template
fix(deps): update dependency eslint to ^9.27.0 - website - website/package.json
chore(deps): update github-actions - workflows - .github/workflows/dependency-review.yml
feat: converted to typescript

fix: config loader clone command issue

fix: adds input validation, uses array arguments, prevented shell spawn

fix: adds failsafe checking for directory location and structure

fix: env-paths change to v2.2.1 which support require and minor code fix

fix: improves test coverage

Adds additional tests for better cove

fix: fixed creating cache directory
Default value should be false, and set to true when cert path is configured
feat: implements config loader to enable remote or external configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants