Fixes #2845. Allow ESMF_CONFIG_FILE to specify ESMF control file #3174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathomp4
added
the
0 Diff
# Conflicts: # CHANGELOG.md
tclune
reviewed
Dec 5, 2024
tclune
reviewed
Dec 5, 2024
tclune
reviewed
Dec 5, 2024
tclune
reviewed
Dec 5, 2024
tclune
requested changes
Dec 5, 2024
Collaborator
tclune
left a comment
tclune
left a comment
There was a problem hiding this comment.
One easy change. One slightly less so.
tclune
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
This PR adds the ability for users to set an environment variable,
ESMF_CONFIG_FILE, that can point to a file where preESMF_Initializevalues can be set. Previously, the file had to be calledESMF.rc. Now, it looks atESMF_CONFIG_FILEand if that isn't set, it then looks forESMF.rc(for backwards compatibility).I have tested this with GEOS and it works as expected.
@tclune if you have time, let me know if you have preferences for what to call the environment variable, etc.
Related Issue
Closes #2845