Instrumenting user methods - setservices, initialize and run

[pchakraborty]

Types of change(s)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Trivial change (affects only documentation or cleanup)
• Refactor (no functional changes, no api changes)

Checklist

• Tested this change with a run of GEOSgcm
• Ran the Unit Tests (make tests)

Description

Related Issue

[tclune]

Code is ok, but the new procedure names need to be modified. I did a few using the GitHub markup, but it will be easier for you to do in your own IDE.

[tclune]

One straightforward, but important change requested. See inline comment.

[mathomp4]

Note: It looks like NAG is unhappy:

[borgq064:164856:0:164856] Caught signal 11 (Segmentation fault: address not mapped to object at address 0x8)
==== backtrace (tid: 164856) ====
 0 0x0000000000016910 __funlockfile()  ???:0
 1 0x00000000001abf3d mapl_distributedprofiler_MP_copy()  /gpfsm/dnb33/gmao_ci/runners/nccs-discover-5/actions-runner/_work/MAPL/MAPL/profiler/DistributedProfiler.F90:92
 2 0x0000000000317f90 mapl3g_genericgridcomp_MP_create_grid_comp_primary()  /gpfsm/dnb33/gmao_ci/runners/nccs-discover-5/actions-runner/_work/MAPL/MAPL/generic3g/GenericGridComp.F90:122
 3 0x00000000004b3b72 mapl3g_drivercap_MP_make_driver()  /gpfsm/dnb33/gmao_ci/runners/nccs-discover-5/actions-runner/_work/MAPL/MAPL/Apps/MAPL_Component_Driver/DriverCap.F90:239
 4 0x00000000004bd47d mapl3g_drivercap_MP_mapl_run_driver()  /gpfsm/dnb33/gmao_ci/runners/nccs-discover-5/actions-runner/_work/MAPL/MAPL/Apps/MAPL_Component_Driver/DriverCap.F90:51

[tclune]

Note: It looks like NAG is unhappy:

Indeed, it appears NAG is struggling with a deep copy of the profiler that was added. I've tried updating some gftl stuff in the profiler from V1 to V2, but it did not change the behavior.

My next guess is that there is a missingTARGET somewhere, but at first glance I'm not seeing anything. I'll open a new ticket to fix this.