Skip to content

Feature/#4259 2nd attempt #4263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tclune merged 19 commits into from
Dec 19, 2025
Merged

Feature/#4259 2nd attempt #4263

tclune merged 19 commits into from
Dec 19, 2025

Conversation

@tclune
Copy link
Collaborator

@tclune tclune commented Dec 17, 2025 •
edited by mathomp4
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@tclune
Fixes #4259 - eliminating some legacy portions of MAPL
c81e0e7 
Previous attempt was too aggressive.  Now only deleting a few high
level gridcomps.
@tclune tclune requested a review from a team as a code owner December 17, 2025 00:41
@tclune tclune requested a review from mathomp4 December 17, 2025 00:41
@tclune tclune changed the base branch from main to release/MAPL-v3 December 17, 2025 12:19
@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 17, 2025
@tclune tclune mentioned this pull request Dec 17, 2025
Closed
pchakraborty
pchakraborty approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@pchakraborty pchakraborty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tclune
Copy link
Collaborator Author

tclune commented Dec 19, 2025

Forcing the merge. I think everything will work and want this in place before the weekend.

@tclune tclune merged commit 881bbea into release/MAPL-v3 Dec 19, 2025
26 of 30 checks passed
@tclune tclune deleted the feature/#4259-2nd-attempt branch December 19, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchakraborty pchakraborty pchakraborty approved these changes

@mathomp4 mathomp4 Awaiting requested review from mathomp4

Assignees

No one assigned

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tclune @pchakraborty @mathomp4