Skip to content

Fixes #4269 #4271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mathomp4 merged 2 commits into from
Dec 18, 2025
Merged

Fixes #4269 #4271

mathomp4 merged 2 commits into from
Dec 18, 2025

Conversation

@tclune
Copy link
Collaborator

@tclune tclune commented Dec 18, 2025

  • Incorrect keys in unit tests
  • Untrapped exceptions in implementation

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@tclune
Fixes #4269
eecf3d6 
 - Incorrect keys in unit tests
 - Untrapped exceptions in implementation
@tclune tclune requested a review from a team as a code owner December 18, 2025 18:04
@tclune tclune added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 18, 2025
darianboggs
darianboggs previously approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@darianboggs darianboggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@tclune
Not sure why NAG worked with the previous commit.
eb46358 
Had set initial hconfig content to '{}', but some unit tests put a
sequence at the top ...
darianboggs
darianboggs approved these changes Dec 18, 2025
View reviewed changes
Copy link
Contributor

@darianboggs darianboggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mathomp4 mathomp4 merged commit ea37f23 into release/MAPL-v3 Dec 18, 2025
27 of 33 checks passed
@mathomp4 mathomp4 deleted the bugfix/#4269-broken-merge-and-tests branch December 18, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darianboggs darianboggs darianboggs approved these changes

Assignees

No one assigned

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tclune @darianboggs @mathomp4