Skip to content

Fix for the issue where user finalize routines were not getting called #4273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pchakraborty merged 1 commit into from
Dec 19, 2025
Merged

Fix for the issue where user finalize routines were not getting called #4273

pchakraborty merged 1 commit into from
Dec 19, 2025

Conversation

@pchakraborty
Copy link
Contributor

@pchakraborty pchakraborty commented Dec 19, 2025

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

Related Issue

@pchakraborty pchakraborty self-assigned this Dec 19, 2025
@pchakraborty pchakraborty requested a review from a team as a code owner December 19, 2025 13:16
@pchakraborty pchakraborty added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 19, 2025
tclune
tclune approved these changes Dec 19, 2025
View reviewed changes
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle.

@pchakraborty pchakraborty merged commit d166b3c into release/MAPL-v3 Dec 19, 2025
49 of 53 checks passed
@pchakraborty pchakraborty deleted the bugfix/pchakrab/outermetacomp-finalize branch December 19, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tclune tclune tclune approved these changes

Assignees

@pchakraborty pchakraborty

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pchakraborty @tclune