Skip to content

Bugfix/#4277 nag failure #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mathomp4 merged 3 commits into from
Dec 23, 2025
Merged

Bugfix/#4277 nag failure #4279

mathomp4 merged 3 commits into from
Dec 23, 2025

Conversation

@tclune
Copy link
Collaborator

@tclune tclune commented Dec 23, 2025 •
edited by mathomp4
Loading

Types of change(s)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)
  • Refactor (no functional changes, no api changes)

Checklist

  • Tested this change with a run of GEOSgcm
  • Ran the Unit Tests (make tests)

Description

This does not solve the NAG problem, but contains several minor code improvements that were found during debugging.

Related Issue

@tclune tclune requested a review from a team as a code owner December 23, 2025 18:58
@tclune tclune added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🛠️ Refactor This is code refactoring 📈 MAPL3 MAPL 3 Related Changelog Skip Skips the Changelog Enforcer labels Dec 23, 2025
@tclune tclune requested a review from mathomp4 December 23, 2025 18:58
@mathomp4
Copy link
Member

mathomp4 commented Dec 23, 2025

I think we are good. I'll merge.

@mathomp4 mathomp4 merged commit 4aa03d2 into release/MAPL-v3 Dec 23, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees

No one assigned

Labels

0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug! Changelog Skip Skips the Changelog Enforcer 📈 MAPL3 MAPL 3 Related 🛠️ Refactor This is code refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tclune @mathomp4