Skip to content

Fix disconnect screen layout for long kick messages#837

Merged
boubou19 merged 2 commits into
GTNewHorizons:masterfrom
alppp:hodgepodge-disconnect-fix
May 21, 2026
Merged

Fix disconnect screen layout for long kick messages#837
boubou19 merged 2 commits into
GTNewHorizons:masterfrom
alppp:hodgepodge-disconnect-fix

Conversation

@alppp

@alppp alppp commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

vanilla hardcodes the title at height/2-50 and the back button below the text. with a long kick message (more than ~20 lines), the wrapped text overflows and overlaps the button.

ports the 1.21 LinearLayout approach: groups title + reason text + button into one block, vertically centers the block on screen, and clamps the button to stay onscreen.

  • title (FONT_HEIGHT = 9px)
  • 20px gap (10 below title + 10 above text)
  • wrapped reason text (n * FONT_HEIGHT)
  • 12px gap (10 below text + 2 above button)
  • button (20px tall)
image

@LazyFlesh

Copy link
Copy Markdown

conflicts, but otherwise it lgtm

@alppp
alppp force-pushed the hodgepodge-disconnect-fix branch from 8e15c83 to ba61b8e Compare May 19, 2026 08:56
@alppp

alppp commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

conflicts, but otherwise it lgtm

fixed

@LazyFlesh LazyFlesh left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boubou19
boubou19 enabled auto-merge (squash) May 21, 2026 00:18
@boubou19
boubou19 merged commit 68c8f30 into GTNewHorizons:master May 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants