Fix crash with disableChunkTerrainGeneration and EndlessIDs

[konkers]

EndlessIDs disallows the suse of getBiomeArray() and setBiomeArray(). Those calls are replaced with getBiomeShortArray() and .setBiomeShortArray() From EndlessIDs' ChunkBiomeHook.

Fixes: #876

[MalTeeez]

I recommend wrinting two mixins across two classes, with one excluding endlessids (the current state) and one requiring it (your change).

[konkers]

I recommend wrinting two mixins across two classes, with one excluding endlessids (the current state) and one requiring it (your change).

Is there a way of detecting the presence of EndlessIDs at runtime and registering the correct mixin?

[konkers]

Ahh I see the .addRequiredMod(TargetedMod.MOD) in Mixins.java

[konkers]

Reposting my questions from (Discord)[https://discord.com/channels/181078474394566657/603348502637969419/1502791599145484318] for context:

I added ENDLESSIDS to Hodgepodge's TargetedMod:

ENDLESSIDS("endlessids"),

However when I try to make registration of MixinChunkProviderServer_DisableTerrain conditional on the lack of EndlessIDs:

    DISABLE_CHUNK_TERRAIN_GENERATION(new MixinBuilder()
            .addCommonMixins("minecraft.MixinChunkProviderServer_DisableTerrain")
            .setApplyIf(() -> TweaksConfig.disableChunkTerrainGeneration)
            .addExcludedMod(TargetedMod.ENDLESSIDS)
            .setPhase(Phase.EARLY)),

I get a java.lang.NoClassDefFoundError: com/gtnewhorizons/navigator/mixins/Mixins on GTHN startup (at 0%). Full stack trace: https://gist.github.com/konkers/2cf6568035cb4eb0bd9fca85efe31121

If I change the TargetedMod def to

ENDLESSIDS("com.falsepattern.endlessids.EndlessIDs", "endlessids")

The mod gets registered even with the .addRequiredMod(TargetedMod.ENDLESSIDS) clause.

Clearly I'm misunderstanding how TargetedMod and ITargetMod work

Here's the change as I've been debugging it: konkers@398e94b

[konkers]

Added EndlessIDs specific version and logic to register the correct mixin

[MalTeeez]

LGTM

[MalTeeez]

Waiting with squash because @Caedis was asking about server compat

[konkers]

Confirmed to work on daily 507 server

[Dream-Master]

@MalTeeez @Caedis merge?

[MalTeeez]

@MalTeeez @Caedis merge?

From what I read in discord, yes. The EID thing caedis was worried about seemed unrelated.