Skip to content

Fails when manifest.json contains comments #115

@melink14

Description

@melink14

Issue

  • I have searched the issues of this repository and believe that this is not a duplicate.

What you did and problem description

I added a comment to my manifest.json to note some potentially surprising choices. This caused the release to fail due to a JSON parsing error.

Of course, pure JSON doesn't allow comments but since chrome does and this is a chrome specific repo, it seems reasonable.

Suggested solution

It looks like we're using another library for JSON parsing so we'd have to complain upstream or use another library/option to make this work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions