Skip to content

Increase stack size on Windows eg. 8MB to match Linux #6809

@boberfly

Description

@boberfly

Version: Gaffer 1.7.0.0-platform
Third-party tools:
Third-party modules:

Description

Now that Gaffer is its own executable, the default stack size needs to be increased for Windows. To match Linux, 8MB should be considered eg. "/STACK:8388608" should be added to the linker flags.

For Python builds in the past, it defaulted to 2MB for release builds:
https://github.com/python/cpython/blob/fdbc135f9cf57599cca8aeeed947d0b736fdb197/PCbuild/python.vcxproj#L98

Currently it is probably the default 1MB which may manifest into a bug in Windows and crash - I only consider 8MB to match Linux as it is something I've had to add for OpenMoonray builds as well, and if that renderer is directly linked to Gaffer in the future the stack needs to be this size for the renderer to work properly.

Steps to reproduce

Debug log

Click to Expand


Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Status

Up Next

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions