Merged
Conversation
johnhaddon
force-pushed
the
removeAppleseed
branch
from
e2eb8f2 to
f9d4ba1
Compare
murraystevenson
approved these changes
Apr 19, 2023
Contributor
murraystevenson
left a comment
murraystevenson
left a comment
There was a problem hiding this comment.
Should we also delete startup/GafferScene/appleseedLights.py while we're at it? Seems there's also a tiny bit of Windows build detritus remaining here.
Otherwise, looks good to me. Thanks for catching that last bit of the docs!
johnhaddon
force-pushed
the
removeAppleseed
branch
from
4d055fb to
9ae97ff
Compare
Member
Author
|
Thanks for catching those last stragglers - I've removed them in 9ae97ff (squashed in since I had to rebase to fix a merge conflict anyway). Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://groups.google.com/g/gaffer-dev/c/Ug7DWUrXMcs