Enhance UNICODE support #192
Conversation
Also to fix GameTechDev#191
Also to fix GameTechDev#191 Signed-off-by: Martin Malik <[email protected]>
There was a problem hiding this comment.
Thank-you for the contribution!
There is one change that is needed (see inline comment). I probably would have gone with wchar_t vs WCHAR, but don't bother changing that now.
I will pull, test, and accept this sometime this week. I can fix that one event then so you don't need to, this is just FYI.
| @@ -2218,7 +2215,7 @@ void PMTraceConsumer::HandleProcessEvent(EVENT_RECORD* pEventRecord) | |||
| }; | |||
| mMetadata.GetEventData(pEventRecord, desc, _countof(desc)); | |||
| event.ProcessId = desc[0].GetData<uint32_t>(); | |||
| event.ImageFileName = desc[1].GetData<std::string>(); | |||
| event.ImageFileName = desc[1].GetData<std::wstring>(); | |||
| event.IsStartEvent = true; | |||
There was a problem hiding this comment.
AFAIK the underlying data for this event is always char, and GetData() doesn't do any conversion, it just accesses the event data as if it were a T. So, we need to leave it as GetData() and then convert here.
In debug build GetData() should be asserting with this change, though you'll only hit this event when processing from an ETL file (--etl_file).
JeffersonMontgomery-Intel
added
bug
enhancement
PresentMon-ConsoleApplication
|
Thanks for the review. I did all changes requested, hope it's OK now :) |
|
Thanks! Testing now and everything looks good. I plumbed it through to the CSV too so should be supported throughout now: 
Should land in main branch |
Also to fix #191