Skip to content

fix: route dev case notifications to main group#68

Merged
aviadr1 merged 2 commits intomainfrom
worktree-260317-1224-7026
Mar 17, 2026
Merged

fix: route dev case notifications to main group#68
aviadr1 merged 2 commits intomainfrom
worktree-260317-1224-7026

Conversation

@aviadr1
Copy link
Copy Markdown

@aviadr1 aviadr1 commented Mar 17, 2026

Summary

  • Dev case creation (case_create with caseType=dev) now sends notifications to the main group instead of the source work group
  • Dev case suggestions (case_suggest_dev) also route to the main group
  • Work case notifications continue going to the source group as before

Test plan

  • Added test: dev case from non-main group notifies main group (tg:111)
  • Added test: work case from non-main group notifies source group (tg:222)
  • All 16 IPC GitHub issues tests pass
  • All 86 IPC tests pass
  • Build clean

🤖 Generated with Claude Code

aviadr1 and others added 2 commits March 17, 2026 12:47
Dev case creation and dev case suggestions now notify the main group
(is_main=1) instead of the source group where the work case is running.
This ensures dev requests are visible to the person who manages them,
not buried in a client-facing work group.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Verifies that dev case creation from a non-main group notifies the
main group, while work cases still notify the source group.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@aviadr1
Copy link
Copy Markdown
Author

aviadr1 commented Mar 17, 2026

Self-Review (Round 1)

Checklist

  • case_create with dev type: notification routed to main group JID via isMain lookup, falls back to resolvedChatJid if no main group
  • case_suggest_dev: notification routed to main group, falls back to source group
  • Work cases unchanged — still notify source group
  • Both paths have fallback if main group not found (graceful degradation)
  • Tests cover the key routing invariants: dev→main, work→source

Path trace

Work agent (telegram_work) → case_suggest_dev IPC
  → targetJid = find(isMain) → tg:111 (main group)
  → sendMessage(tg:111, "💡 Dev case suggested...")

Work agent (telegram_work) → case_create with caseType=dev
  → notifyJid = find(isMain) → tg:111
  → sendMessage(tg:111, "📋 New dev case created...")

Work agent (telegram_work) → case_create with caseType=work  
  → notifyJid = resolvedChatJid → tg:222 (source group)
  → sendMessage(tg:222, "📋 New work case created...")

LGTM — ready to merge.

@aviadr1 aviadr1 merged commit 8474c75 into main Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant