Skip to content

(V3) Class creation templates are not correct for projects using Rowan package convention #963

@dalehenrich

Description

@dalehenrich

Rowan[c2df238] has a couple of class creation template methods in the class RwPrjBrowserToolV2 (Rowan projectTools browser):

  1. Rowan projectTools browser classCreationTemplateForClass:
  2. RwPrjBrowserToolV2>>classCreationTemplateForClass:hybridBrowser:
    That produce a class creation templage for the given class.

Unfortunately projects that are using the Rowan package convention (like RowanSample9V4:spec_0057) can display incorrect results

If you load the following project into a Rowan 3 image:

Rowan 
  projectFromUrl: 'https://raw.githubusercontent.com/dalehenrich/RowanSample9V4/refs/heads/spec_0057/rowan/specs/spec_0057.ston' 
  projectsHome: '$PROJECTS_HOME'

and then run the following expressions:

"#1"
	Rowan projectTools browser classCreationTemplateForClass:  RowanSample9V4Class1.
'Object rwSubclass: ''RowanSample9V4Class1''
	instVarNames: #( ivar1)
	classVars: #()
	classInstVars: #()
	poolDictionaries: #()
	category: ''RowanSample9V4-Core''
	packageName: ''RowanSample9V4-Core''
	options: #()
`
"#2"
	Rowan projectTools browser classCreationTemplateForClass: RowanSample9V4Class1 hybridBrowser: true.
'Object rwSubclass: ''RowanSample9V4Class1''
	instVarNames: #( ivar1)
	classVars: #()
	classInstVars: #()
	poolDictionaries: #()
	category: ''RowanSample9V4-Core''
	options: #()
'
"#3"
	Rowan projectTools browser classCreationTemplateForClass: RowanSample9V4Class1 hybridBrowser: false.
'Object rwSubclass: ''RowanSample9V4Class1''
	instVarNames: #( ivar1)
	classVars: #()
	classInstVars: #()
	poolDictionaries: #()
	category: ''RowanSample9V4-Core''
	packageName: ''RowanSample9V4-Core''
	options: #()
'

You'll get these results:

"#1"
'Object rwSubclass: ''RowanSample9V4Class1''
	instVarNames: #( ivar1)
	classVars: #()
	classInstVars: #()
	poolDictionaries: #()
	category: ''RowanSample9V4-Core''
	packageName: ''RowanSample9V4-Core''
	options: #()
'

"#2"
'Object rwSubclass: ''RowanSample9V4Class1''
	instVarNames: #( ivar1)
	classVars: #()
	classInstVars: #()
	poolDictionaries: #()
	category: ''RowanSample9V4-Core''
	options: #()
'

"#3"
'Object rwSubclass: ''RowanSample9V4Class1''
	instVarNames: #( ivar1)
	classVars: #()
	classInstVars: #()
	poolDictionaries: #()
	category: ''RowanSample9V4-Core''
	packageName: ''RowanSample9V4-Core''
	options: #()
'

The "#1" and "#3" class creation templates are correct, as they include fields for both the category and packageName. "#2" is incorrect, because by definition, the Rowan package convention allows one to specify the category and packageName independently and "#2" does not allow independent specification of the packageName (which can be used to change which package the the class is in).

In the long term we should remove the method RwPrjBrowserToolV2>>classCreationTemplateForClass:hybridBrowser: completely.

BTW, the expression Rowan projectTools browser classCreationTemplateForClass: RowanSample9V4Class1., which is the preferred method to use is present and works correctly in a 3.7.4.1 stone ...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions