Windows Defender found threat

[Klewerro]

Today after unpacking zip (v2.4) my 'antivirus' (default Windows (10) Defender) found this:

Translation:
Threat found - action is required.

State: Active
Threat detected: TrojanHorse:Win32/Spursint.Q!cl
Alert level: respectable
Date: ...
Category: Trojan Horse
Details: This program is dangerous and executes the attacker's instructions.
And file source to file bellow.

---

I know that's probably fake alarm, but what does this file do?

[rom1v]

The Windows release is cross-compiled from linux, so it uses MinGW.

And anti-virus don't like binaries compiled by MinGW (even a simple Hello World).

Users reported the same issue on scrcpy:

• 17 threats found by Virustotal in downloaded 32bit zip scrcpy#1102
• https://www.reddit.com/r/Malware/comments/erricw/binaries_generated_by_mingw32_detected_as_trojan/

[Biswa96]

While testing this issue, I can not compile relay-rust in Debian. The error output is as following.

error: linking with `x86_64-w64-mingw32-gcc` failed: exit code: 1
  |
  = note: "x86_64-w64-mingw32-gcc" "-fno-use-linker-plugin" "-Wl,--nxcompat" "-nostdlib" "-m64" "/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/crt2.o" "/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/rsbegin.o" "-L" "/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib" "/home/x/gnirehtet/relay-rust/target/x86_64-pc-windows-gnu/release/deps/gnirehtet-8e0e74f9c78ed1b3.gnirehtet.43zv75vw-cgu.0.rcgu.o" "-o" "/home/x/gnirehtet/relay-rust/target/x86_64-pc-windows-gnu/release/deps/gnirehtet-8e0e74f9c78ed1b3.exe" "-Wl,--gc-sections" "-nodefaultlibs" "-L" "/home/x/gnirehtet/relay-rust/target/x86_64-pc-windows-gnu/release/deps" "-L" "/home/x/gnirehtet/relay-rust/target/release/deps" "-L" "/home/x/.cargo/registry/src/github.1485827954.workers.dev-1ecc6299db9ec823/winapi-x86_64-pc-windows-gnu-0.4.0/lib" "-L" "/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/tmp/rustcv66ScV/libbacktrace_sys-583b927240902ae3.rlib" "-Wl,--end-group" "/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/libcompiler_builtins-8d584b80572e52da.rlib" "-Wl,-Bdynamic" "-ladvapi32" "-lws2_32" "-lkernel32" "-lwinapi_advapi32" "-lwinapi_cfgmgr32" "-lwinapi_fwpuclnt" "-lwinapi_gdi32" "-lwinapi_kernel32" "-lwinapi_msimg32" "-lwinapi_ntdll" "-lwinapi_opengl32" "-lwinapi_synchronization" "-lwinapi_user32" "-lwinapi_winspool" "-lwinapi_ws2_32" "-ladvapi32" "-lws2_32" "-luserenv" "-Wl,-Bstatic" "-lgcc_eh" "-lpthread" "-Wl,-Bdynamic" "-lmingwex" "-lmingw32" "-lgcc" "-lmsvcrt" "-lmsvcrt" "-luser32" "-lkernel32" "/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/rsend.o"
  = note: /usr/bin/x86_64-w64-mingw32-ld: l/home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/crt2.o:crtexe.c:(.rdata$.refptr.__onexitbegin[.refptr.__onexitbegin]+0x0): undefined reference to `__onexitbegin'
          /usr/bin/x86_64-w64-mingw32-ld: /home/x/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/crt2.o:crtexe.c:(.rdata$.refptr.__onexitend[.refptr.__onexitend]+0x0): undefined reference to `__onexitend'
          collect2: error: ld returned 1 exit status

[rom1v]

@Biswa96 rust-lang/rust#48272

cd ~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-pc-windows-gnu/lib/
mv crt2.o crt2.o.bak
cp /usr/x86_64-w64-mingw32/lib/crt2.o .

[Biswa96]

Compiler warnings in dev branch.

Click to open the details

warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
   --> src/execution_error.rs:155:62
    |
155 |             CommandExecutionError::ProcessIo(ref err) => err.description(),
    |                                                              ^^^^^^^^^^^
    |
    = note: `#[warn(deprecated)]` on by default

warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
   --> src/execution_error.rs:156:66
    |
156 |             CommandExecutionError::ProcessStatus(ref err) => err.description(),
    |                                                                  ^^^^^^^^^^^

warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()
   --> src/execution_error.rs:157:55
    |
157 |             CommandExecutionError::Io(ref err) => err.description(),
    |                                                       ^^^^^^^^^^^

[rom1v]

https://blog.rust-lang.org/2020/03/12/Rust-1.42.html#whats-in-1.42.0-stable

Since Rust 1.42… released yesterday.

Fixes welcome :)