ci: bump GitHub Actions to Node 24 compatible versions#185
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughCI workflow: bumped Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor User
participant Workflow
participant Preflight
participant GH_API as "GitHub API (gh)"
participant Build
participant Release
participant Publish as "Publish Jobs"
User->>Workflow: trigger (push / workflow_dispatch)
Workflow->>Preflight: run preflight (resolve `tag`, `is_prerelease`)
Preflight->>GH_API: check/create tag via `gh api`
GH_API-->>Preflight: tag exists / created
Preflight-->>Workflow: outputs `tag`, `is_prerelease`
Workflow->>Build: checkout `ref=preflight.tag` and build
Build-->>Workflow: artifacts / success
alt is_prerelease == 'false'
Workflow->>Release: create GitHub Release (tag=preflight.tag, prerelease=false)
Release->>Publish: trigger publish jobs (crates / npm / pypi / homebrew)
else prerelease
Workflow-->>Publish: skip gated publish jobs
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Poem
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Line 100: Update the GitHub Actions artifact steps to use the newer action
versions to avoid Node 20 deprecation warnings: replace uses:
actions/upload-artifact@v5 with uses: actions/upload-artifact@v6 and replace
uses: actions/download-artifact@v5 with uses: actions/download-artifact@v7
(these are the unique identifiers to find in the workflow: upload-artifact and
download-artifact uses entries).
- Around line 34-46: The release workflow currently creates TAG locally but
doesn't export it as RELEASE_TAG and doesn't pass it into
softprops/action-gh-release.tag_name, and the publish job guards still inspect
github.ref; update the workflow so the created TAG is exported/assigned to
env.RELEASE_TAG (derive from github.event.inputs.tag), pass that env.RELEASE_TAG
into softprops/action-gh-release via tag_name, and change the publish job
conditional checks (publish-crates, publish-npm, publish-pypi, update-homebrew)
to use !contains(env.RELEASE_TAG, '-') instead of !contains(github.ref, '-') so
prerelease tags like v0.1.0-rc1 are evaluated correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 74dfe541-44aa-4b21-ac01-9f6507e824f9
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/release.yml
George-RD
force-pushed
the
claude/complete-release-workflow-EQF6s
branch
from
d02fc27 to
8c29213
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
253-256:⚠️ Potential issue | 🔴 Criticalx86_64-apple-darwin checksum update will fail — target is not built.
Line 254 updates the checksum for
x86_64-apple-darwin, but this target is commented out of the build matrix (lines 77-79). Thechecksums.txtwon't contain this entry, soget_sha x86_64-apple-darwinreturns empty, and thesedcommand will set an emptysha256in the Homebrew formula.Either remove line 254 to match the current build matrix, or add a guard to skip missing targets gracefully.
🐛 Proposed fix: Remove x86_64-apple-darwin update
# Update checksums using URL context to match the right sha256 line # Each sha256 line follows its URL line, so we match by the target in the URL sed -i "/aarch64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha aarch64-apple-darwin)\"/;}" "$FORMULA" - sed -i "/x86_64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha x86_64-apple-darwin)\"/;}" "$FORMULA" sed -i "/aarch64-unknown-linux-gnu/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha aarch64-unknown-linux-gnu)\"/;}" "$FORMULA" sed -i "/x86_64-unknown-linux-gnu/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha x86_64-unknown-linux-gnu)\"/;}" "$FORMULA"Note: The Homebrew formula itself (
homebrew-tap/Formula/mag.rb) may also need to be updated to remove the x86_64-apple-darwin resource block, since binaries are no longer published for Intel Macs.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 253 - 256, The sed invocation that updates the x86_64-apple-darwin checksum (the line calling get_sha x86_64-apple-darwin against "$FORMULA") will set an empty sha256 because that target is not built; either remove that sed line entirely to match the build matrix, or wrap it with a guard that calls get_sha first and only runs the sed replacement if the returned value is non-empty (i.e., check the output of get_sha x86_64-apple-darwin before invoking the sed against "$FORMULA").
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/release.yml:
- Around line 253-256: The sed invocation that updates the x86_64-apple-darwin
checksum (the line calling get_sha x86_64-apple-darwin against "$FORMULA") will
set an empty sha256 because that target is not built; either remove that sed
line entirely to match the build matrix, or wrap it with a guard that calls
get_sha first and only runs the sed replacement if the returned value is
non-empty (i.e., check the output of get_sha x86_64-apple-darwin before invoking
the sed against "$FORMULA").
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: ec5e25b2-5899-4030-b6d3-6559a5bd5deb
📒 Files selected for processing (1)
.github/workflows/release.yml
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
253-254:⚠️ Potential issue | 🟠 MajorChecksum update for non-existent build target will corrupt the Homebrew formula.
Line 254 updates the sha256 for
x86_64-apple-darwin, but this target was removed from the build matrix (see lines 77-79). Theget_sha x86_64-apple-darwinreturns empty, resulting insha256 ""in the formula.Either remove this line (if the Homebrew formula no longer supports Intel Mac) or handle the missing checksum gracefully.
🔧 Option 1: Remove the line if Intel Mac is no longer supported in the formula
sed -i "/aarch64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha aarch64-apple-darwin)\"/;}" "$FORMULA" - sed -i "/x86_64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha x86_64-apple-darwin)\"/;}" "$FORMULA" sed -i "/aarch64-unknown-linux-gnu/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha aarch64-unknown-linux-gnu)\"/;}" "$FORMULA"🔧 Option 2: Skip update if checksum is missing
sed -i "/aarch64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha aarch64-apple-darwin)\"/;}" "$FORMULA" - sed -i "/x86_64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha x86_64-apple-darwin)\"/;}" "$FORMULA" + X86_DARWIN_SHA="$(get_sha x86_64-apple-darwin)" + if [ -n "$X86_DARWIN_SHA" ]; then + sed -i "/x86_64-apple-darwin/{n;s/sha256 \"[^\"]*\"/sha256 \"$X86_DARWIN_SHA\"/;}" "$FORMULA" + fi sed -i "/aarch64-unknown-linux-gnu/{n;s/sha256 \"[^\"]*\"/sha256 \"$(get_sha aarch64-unknown-linux-gnu)\"/;}" "$FORMULA"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/release.yml around lines 253 - 254, The sed invocation that updates the x86_64-apple-darwin checksum will insert an empty sha256 because get_sha x86_64-apple-darwin returns nothing; either remove the second sed line that references x86_64-apple-darwin from the release.yml (if Intel Mac is no longer supported) or wrap the update so it only runs when get_sha x86_64-apple-darwin returns a non-empty value (call get_sha first, check the result, and only run the sed that edits FORMULA when the checksum is present) to avoid producing sha256 "" in the Homebrew formula.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/release.yml:
- Around line 253-254: The sed invocation that updates the x86_64-apple-darwin
checksum will insert an empty sha256 because get_sha x86_64-apple-darwin returns
nothing; either remove the second sed line that references x86_64-apple-darwin
from the release.yml (if Intel Mac is no longer supported) or wrap the update so
it only runs when get_sha x86_64-apple-darwin returns a non-empty value (call
get_sha first, check the result, and only run the sed that edits FORMULA when
the checksum is present) to avoid producing sha256 "" in the Homebrew formula.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 25adffb6-2134-4b4f-b8d3-79e185cf3a31
📒 Files selected for processing (2)
.github/workflows/ci.yml.github/workflows/release.yml
- Add preflight job: resolves tag, detects prerelease, creates tag via GitHub API if missing (lightweight tag, no committer identity needed) - Pass explicit tag_name to softprops/action-gh-release (workflow_dispatch sets GITHUB_REF to branch, not tag) - Use shell case for prerelease detection (avoids grep quoting issues) - Publish conditions use preflight outputs instead of github.ref - All checkout steps use ref from preflight (correct commit for both triggers) - Retry loop for gh release download (API eventual consistency) - Bump actions to Node 24: checkout v5, upload-artifact v6, download-artifact v7, setup-node v5, setup-python v6 https://claude.ai/code/session_01G9KJ8D8R2m6ZMTz5MjVvrt
George-RD
force-pushed
the
claude/complete-release-workflow-EQF6s
branch
from
8c29213 to
800aab6
Compare
2 participants
Summary
actions/checkoutv4 → v5,upload/download-artifactv4 → v5,setup-nodev4 → v5,setup-pythonv5 → v6ci.ymlandrelease.ymlupdatedNode.js 20 removal deadline is September 2026 — this gets ahead of it.
https://claude.ai/code/session_01G9KJ8D8R2m6ZMTz5MjVvrt
Summary by CodeRabbit