Skip to content

Add Travis testing. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2016
Merged

Add Travis testing. #69

merged 1 commit into from
Sep 29, 2016

Conversation

micahcochran
Copy link
Contributor

@micahcochran micahcochran commented Aug 27, 2016

This is current failing until PR #68 is (or some similar solution) has been merged. It is good that it is failing because it shows that there is a problem running the doctests.

If PR #68 gets merged (or some similar solution), this issue can be closed and reopened to rerun Travis tests.

I added a few small changes so that the number of failures gets reported to the status code. Any status code that is zero (0) is Travis considers a success, anything other status code is a failure. (In this case the status code is 5 because 5 tests fail.) Also, added that verbosity can be turned off from the function. So, you can quietly run the doctests by calling shapefile.test(verbose=False).

@micahcochran
Copy link
Contributor Author

Since PR #68 was merged, Travis testing now passes.

@karimbahgat
Copy link
Collaborator

@micahcochran, to be sure if I understand it correctly, the purpose of this PR is to easily check the status of Travis testing of the current state of the repository, a sort of "canary in the mine"? And the tests are run when we close and rerun this PR?

@micahcochran
Copy link
Contributor Author

@karimbahgat The intent of this PR is to to enable the testing feature on Travis. It is a canary in the mine so to speak. If this is merged it, for every PR submitted Travis will test it, and pass or fail based on the doctests. (Testing can be opted out of for if unneeded.)

My experience with using Travis has been with pyproj using it for a few months. Matplotlib uses Travis and Appveyor for testing.

The reason I closed and reopened this one was to show you that it now shows that with the changes to the repository that it went from failing to passing. That's a way to forced Travis to retest.

Travis, used in this way, informs you of if it passes the project's testing suite. You still have the ability to merge a failing test, if necessary.

@karimbahgat karimbahgat merged commit 49f15c5 into GeospatialPython:master Sep 29, 2016
@micahcochran
Copy link
Contributor Author

Thanks

@micahcochran micahcochran deleted the add-travis3 branch September 29, 2016 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants