Skip to content

Conversation

@luffs
Copy link

@luffs luffs commented Sep 25, 2017

The index of the element of the array is not included, but I don't really need it so ¯\_(ツ)_/¯

The index of the element of the array is not included, but I don't really need it so ¯\_(ツ)_/¯
@GianlucaGuarini
Copy link
Owner

@luffs thanks for your pull request but at moment I don't want to add this feature to icaro keeping it simpler. You can keep using your branch for your project.

Side notes:

  • you have changed the generated code and not the source code in the src folder so you might update the src/index.js file if you want to keep your fork clear
  • extending all the icaro instances adding the .parent property by default might be dangerous because you are modifying the internal structure of your objects and this can lead you to unexpected bugs

@luffs
Copy link
Author

luffs commented Sep 25, 2017

Fair enough, and thanks for taking time to answer and giving feedback :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants