Next page cell is visible when there is no next page

[rizwankce]

Version: 1.10.0(1899)
Device: iPhone 7 plus - iOS 11

I have only one pending notification to read and when I open the app (or refresh notifications) getting "Load Page 2" cell. Clicking on that making a network request and hides the "Load Page" cell.

Is it expected to have load page cell though there is no next page to load?

[Sherlouk]

I understand why we have this issue (because of the response we get from GitHub makes it very difficult to have the toggle between read/unread and still have paging)

I feel like we need to re-investigate how we handle paging and multiple requests across the board.

Ultimately the issue is there's no way to get all the unread messages first, it's done by "Last Updated" so this could mean if you read the most up-to-date ones but leave a couple further down the list unread then there's no real way to know about those.

One possible solution is to break it up into two requests (one for unread, one for all) but this would be a bit slower!

[BasThomas]

It's an interesting one, yeah. Also a dupe of #47, but maybe we should keep this one open as there's some useful discussion on the issue.

[rnystrom]

@Sherlouk I'm leaning towards the "multiple requests" strategy at this point. Also very annoyed w/ the next-page cell, personally. It's an issue w/ GitHub where the Link header will sometimes work and sometimes not.

Another idea is to do something like Mail.app and just show only one view, with a button to tap into a "view all" mode or something.

[Sherlouk]

If we were to break them up it would make #61 a lot more doable!

[rnystrom]

It looks like Tabman still allows h-scroll gestures. Maybe we change the inbox into a Tabman page setup where each tab is its own VC? We'd have to separate the VCs into "Unread" and "Read" though (no "All").