New Bookmarks feature that syncs to iCloud

[rnystrom]

• Migrate old Bookmark models from BookmarkStore to new storage using only the GraphQL node id in iCloud's ubiquitous store
  • Take old model, build GraphQL query, find Node id for each object, append to new iCloud key store
• Architecture that enables unit testing of VCs
• New UI will fetch objects along w/ status from GraphQL (e.g. issue/PR open+closed+merged)

Much more to come. Putting this up now for early eyeballs.

Fixes #2379, #2377, #702, #683

[BasThomas]

Cool stuff!

[rnystrom]

Slowly growing in complexity! Now RepositoryViewController loads default branch and issues-enabled when the VC loads. No need to pass that around anymore.

[rnystrom]

[Huddie]

Looks awesome!

_{Sent with GitHawk}

[ijm8710]

Yes, dynamic icons for open closed! How about sortable and having a count like bookmarks (7)

[rnystrom]

@ijm8710 lol one thing a time

_{Sent with GitHawk}

[ijm8710]

Hah what I meant to say was looks awesome...so far :)

[ijm8710]

That was a yes like oh yes..haha

[rnystrom]

Ditching the swipe-to-delete in favor of just opening the issue/repo and un-bookmarking the item. We can bring back swipe if that becomes a huge issue, but I never used it.

[ijm8710]

I always hated swipe with the concern that downswiping too fast and at the wrong angle would unintentionally remove one 🤷‍♂️

[rnystrom]

@ijm8710 i haven’t forgot about moving either, would like to explore that. I don’t think it’d be too hard, and more valuable than swipe-delete!

_{Sent with GitHawk}

[ijm8710]

Did anyone’s bookmark order get all out of wack :(

[ijm8710]

^did this happen to you as well @rnystrom? Not a complaint; the bkmk refactor is great so far!

Just curious if the reordering was a) expected b) unlikely to occur again as I might spend a little time removing and adding them back manually to get them in the same order as before as im slightly ocd about that —obv if/once true native reordering comes if that’s still the plan that would be even easier

[Sherlouk]

@ijm8710 @rnystrom Just updated to latest TF (was a few behind) to have a look at this and yea mine have changed order (though I'm not particularly fussed about that) but also a bunch of my bookmarks have been deleted!

Curious if that's intended too? If it helps I believe some/most were in private/2fa orgs.

Also a nice improvement is that deleted issues/orgs seem to disappear too!

[rnystrom]

@Sherlouk ack will take a look at the private repos part and see if there’s an early return parsing results that might have dropped it. Def my biggest concern with this is the migration deletes data.

_{Sent with GitHawk}

[ijm8710]

What’s also different is new bookmarks add to bottom of list as opposed to top so I feel in addition to reshuffling it essentially reversed the order as well. Reason I brought up ordering is I felt I lost some bookmaks as well and without a total count or a recognizable order it’s hard to pinpoint that

[BasThomas]

Feel free to open up an issue for that @ijm8710 :)

_{Sent with GitHawk}

[ijm8710]

Would you really want separate tickets for 1) lost order 2) reversed order 3) lost bookmarks?

I would feel it makes a lot more sense to streamline everything related in the same thread, especially if it’s all related to this PR?

[BasThomas]

Would you really want separate tickets for 1) lost order 2) reversed order 3) lost bookmarks?

Yep! This pull request has already been merged and thus not very visible. Small, easy to tackle questions can be answered and seen by more people and then are more easy to implement separately or side-by-side.

_{Sent with GitHawk}