Feat: Add support for .codeqlversion #117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a feature to support specifying the CodeQL CLI version via a .codeqlversion file when no explicit version is provided through the input.
- Added conditional logic in the install-codeql GitHub Action to detect an empty CODEQL_CLI_VERSION and read the version from the .codeqlversion file.
Files not reviewed (1)
- .codeqlversion: Language not supported
| @@ -26,6 +26,12 @@ runs: | |||
| CODEQL_HOME: ${{ github.workspace }}/codeql_home | |||
| CODEQL_CLI_VERSION: ${{ inputs.codeql-cli-version }} | |||
| run: | | |||
| if [ -z "$CODEQL_CLI_VERSION" ]; then | |||
| echo "No CodeQL CLI version specified. Reading from .codeqlversion file." | |||
There was a problem hiding this comment.
Consider adding a check to ensure the .codeqlversion file exists before attempting to read it, to prevent potential errors if the file is missing.
Suggested change
| echo "No CodeQL CLI version specified. Reading from .codeqlversion file." | |
| echo "No CodeQL CLI version specified. Checking for .codeqlversion file." | |
| if [ ! -f ./.codeqlversion ]; then | |
| echo "Error: .codeqlversion file not found. Please specify a CodeQL CLI version." >&2 | |
| exit 1 | |
| fi | |
| echo "Reading CodeQL CLI version from .codeqlversion file." |
Copilot uses AI. Check for mistakes.
GeekMasher
changed the title
michaelnebel
approved these changes
Apr 22, 2025
|
Yes. Let me do that tomorrow before we merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.