Skip to content

Uploading AppVeyor artifacts fails when doing Pull Request #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gep13 opened this issue Nov 18, 2016 · 3 comments
Closed

Uploading AppVeyor artifacts fails when doing Pull Request #1088

gep13 opened this issue Nov 18, 2016 · 3 comments
Assignees
@gep13

Comments

@gep13
Copy link
Member

gep13 commented Nov 18, 2016

This is due to the fact that an attempt is made to upload the releasenotes.md file, however, this file does not exist, since it will ONLY be created when a GitHub Token exists, and this will only be the case when running on the master branch, as this is the only time the Environment Variable will exist.
@gep13 gep13 added the bug label Nov 18, 2016
@gep13 gep13 self-assigned this Nov 18, 2016
gep13 added a commit to gep13/GitVersion that referenced this issue Nov 18, 2016
@gep13
(GitToolsGH-1088) Control when attempt is made to upload releasenotes.md
2fda16d 
- Only do this when on the master branch of main GitVersion repo, and when it is NOT a PullRequest
- Ensure that releasenotes.md exists prior to attempting upload
gep13 added a commit to gep13/GitVersion that referenced this issue Nov 18, 2016
@gep13
(GitToolsGH-1088) Control when attempt is made to upload releasenotes.md
8a9ae45 
- Only do this when on the master branch of main GitVersion repo, and when it is NOT a PullRequest
- Ensure that releasenotes.md exists prior to attempting upload
JakeGinnivan added a commit that referenced this issue Nov 26, 2016
@JakeGinnivan
Merge pull request #1093 from gep13/bug/GH-1088
529981e 
Control when an attempt is made to upload releasenotes.md
@asbjornu
Copy link
Member

Wasn't this fixed by @JakeGinnivan over the last weekend?

@pascalberger
Copy link
Member

This should be fixed by #1093

@gep13 gep13 mentioned this issue Nov 28, 2016
Merged
@gep13
Copy link
Member Author

gep13 commented Nov 28, 2016

@pascalberger agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gep13 gep13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asbjornu @gep13 @pascalberger