Skip to content

No way to have an x.x.0 release using GitHubFlow #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
distantcam opened this issue Mar 27, 2014 · 10 comments
Closed

No way to have an x.x.0 release using GitHubFlow #124

distantcam opened this issue Mar 27, 2014 · 10 comments

Comments

@distantcam
Copy link
Contributor

Correct me if I'm wrong but, when using GitHubFlow the version is gotten from the latest tag, and then the patch number is always incremented by 1, even if there are no other commits after the tag.

This means if you tag head with 1.0.0 your build will come out with 1.0.1. Is there no way to have a 1.0.0 release?

@JakeGinnivan
Copy link
Contributor

That is a bug, in GitHubFlowVersion the tagged version was built using that tag, will fix

@JakeGinnivan
Copy link
Contributor

Actually, that is right

You use NextVersion.txt to say the next verison is 2.0.0, then it will be building 2.0.0+commits

Once you tag 2.0.0, 2.0.1 will be building. The idea is that it works with continuous delivery, and you can release the package that was just built, rather than tagging then build again and release

@JakeGinnivan
Copy link
Contributor

We were thinking about having markers in commit messages supported too.

i.e Breaking: Added an optional parameter to Foo, would cause the major to be bumped. Added: Should.CompleteIn overload would cause minor to bump.

Obviously if you had both major, and another major and a minor since the last tag only the major would be bumped giving you the next major version being built

@distantcam
Copy link
Contributor Author

Is that NextVersion.txt thing documented anywhere?

@JakeGinnivan
Copy link
Contributor

Currently at https://github.com/JakeGinnivan/GitHubFlowVersion#how-to-increase-the-semantic-version (the old project)

I am working on bringing the docs for GitVersion up to date, but currently it only works with the GitHubFlow workflow (no develop branch) and the docs for that are pretty non-existent

@andreasohlund
Copy link
Contributor

And for GitFlow we have it sorted out using a release-{new major}.0.0
branch to handle the major bumps

Minor bumps are automatic

On Thu, Mar 27, 2014 at 9:25 AM, Jake Ginnivan [email protected]:

Currently at
https://github.com/JakeGinnivan/GitHubFlowVersion#how-to-increase-the-semantic-version(the old project)

I am working on bringing the docs for GitVersion up to date, but currently
it only works with the GitHubFlow workflow (no develop branch) and the docs
for that are pretty non-existent

Reply to this email directly or view it on GitHubhttps://github.com//issues/124#issuecomment-38778268
.

@distantcam
Copy link
Contributor Author

About NextVersion.txt - that doesn't work either. Same deal, it reads the version from the file, then increments the patch number by 1.

@JakeGinnivan
Copy link
Contributor

@distantcam do you have a develop branch in your repo?

@JakeGinnivan
Copy link
Contributor

I'm pretty sure this works now. See https://github.com/Particular/GitVersion/blob/master/AcceptanceTests/GitHubFlow/MasterTests.cs#L29 which tests this scenario

Reopen (try with source version, not released) if it does not work

@distantcam
Copy link
Contributor Author

I'm still not sure this works the way I expect it.

For example, I'm trying to get my current head to be 1.2.0+0. This requires me to have a tag of 1.1.0 (or anything < 1.2.0) and a NextVersion.txt with 1.2.0 in it.

But when I look at my repo the 1.2.0+0 build is tagged as 1.1.0. Does that seem right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants