[Bug] Typo in GitVersion.MsBuild.targets #2582
Comments
|
|
|
Happy to include it in my current PR, or do you prefer separate PRs for different fixes? |
MarkusHorstmann
added a commit
to MarkusHorstmann/GitVersion
that referenced
this issue
Feb 5, 2021
…eleaseLabelWithDash
3 tasks
|
Since #2581 does not deal with the MSBuild task directly, fixing the typo in a separate PR would be preferable. 🙏🏼 |
|
Ok, I'll revert it there and kick off a separate PR. |
MarkusHorstmann
added a commit
to MarkusHorstmann/GitVersion
that referenced
this issue
Feb 5, 2021
…eleaseLabelWithDash
3 tasks
MarkusHorstmann
added a commit
to MarkusHorstmann/GitVersion
that referenced
this issue
Feb 5, 2021
…ion_PreReleaseLabelWithDash" This reverts commit f2b6131.
asbjornu
added a commit
that referenced
this issue
Feb 6, 2021
#2582: GitVersionMsBuild.Targets: fix typo in GitVersion_PreReleaseLabelWithDash
arturcic
pushed a commit
to MarkusHorstmann/GitVersion
that referenced
this issue
Feb 7, 2021
…ion_PreReleaseLabelWithDash" This reverts commit f2b6131.
arturcic
pushed a commit
that referenced
this issue
Feb 7, 2021
…eleaseLabelWithDash" This reverts commit f2b6131.
|
🎉 This issue has been resolved in version 5.6.5 🎉 Your GitReleaseManager bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
<DefineConstants Condition=" '$(GitVersion_PreReleaseLabelWithDash)' != '' ">GitVersion_PreReleaseLabelWithDash=$(GitVersion_PreReleaseLabeWithDashl);$(DefineConstants)</DefineConstants>should likely be
<DefineConstants Condition=" '$(GitVersion_PreReleaseLabelWithDash)' != '' ">GitVersion_PreReleaseLabelWithDash=$(GitVersion_PreReleaseLabelWithDash);$(DefineConstants)</DefineConstants>Noticed doing other changes, but don't have a way to test this.
Expected Behavior
Unknown
Actual Behavior
Unknown
Possible Fix
See above.
Steps to Reproduce
Unknown
Context
Code inspection
Your Environment
The text was updated successfully, but these errors were encountered: