Skip to content

Allow {BranchName} in tag config #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
o-o00o-o opened this issue Oct 5, 2015 · 3 comments
Closed

Allow {BranchName} in tag config #664

o-o00o-o opened this issue Oct 5, 2015 · 3 comments

Comments

@o-o00o-o
Copy link

o-o00o-o commented Oct 5, 2015

As per #632

Currently the prerelease tag configuration is fine except for feature branches where there can be many of them at the same time for the same version. The problem here is that with the current useBranchName config, feature branches starting with "a" are considered the lowest prerelease version and any feature branch starting with "z" will be the latest one. To solve this we should be able to prefix the feature braches "something." so they can be positioned in the desired order consistently no matter what the name of the feaure branch.

E.g feature/AddForgottenPassword and feature/ZeroAllowedInAmount could be v1.0.0-alpha.AddForgottenPassword and v1.0.0-alpha.ZeroAllowedInAmount which would then both be seen as the same level compared with the other develop/release and master branches.

To achieve this @JakeGinnivan suggested using c# string interpolation so in config something like:

tag: alpha.{BranchName}

For branch feature/FixLogin
Would produce a semver like 0.0.0-alpha.FixLogin

@gusztavvargadr
Copy link
Contributor

I just wanted to double check if is #766 what you expect, but I see it just got merged, thanks @JakeGinnivan :)

@JakeGinnivan
Copy link
Contributor

Yep, exactly what I was after.

I think in v4 this will become the default behaviour.

JakeGinnivan added a commit that referenced this issue Jan 31, 2016
…ame-variable-in-tag-configuration

Document branch name variable usage in tag configuration #664
@mkoertgen
Copy link
Contributor

Great feature!

+1 for making tag: alpha.{BranchName} the new default for feature branches.

BTW, this feature enables to workaround problems with nuget pack when feature branches begin with a number, cf. NuGet/Home#1743, which seems to be common practice when working with issue trackers.

Very cool. Using it straight away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants