Skip to content

AssemblyFileVersionAttribute format configurable #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrgei opened this issue Jun 1, 2016 · 6 comments
Closed

AssemblyFileVersionAttribute format configurable #886

chrgei opened this issue Jun 1, 2016 · 6 comments

Comments

@chrgei
Copy link

chrgei commented Jun 1, 2016

Thanks for this great tool.
It would be very nice, if we can configure the format of the AssemblyFileVersionAttribute with an extra variable. Is this possible for the next release?

@JakeGinnivan
Copy link
Contributor

Could you give examples, or even implement a PR which adds this :)

@chrgei
Copy link
Author

chrgei commented Jul 12, 2016

Yes I can. AssemblyFileVersionAttribute is formated as "Major.Minor.Patch.0" with fixed "0". We want it to format as "Major.Minor.Patch.CommitsSinceVersionSource". I know, it's not realy SemVer but it is better suited to our company rules.

@Eregrith
Copy link

I'm interested to know if AssemblyInformationalVersion has its format configurable as well. As mentionned in #1161, NuGet fails to parse current AssemblyInformationalVersion's format (Because it uses SemVer 2.0 dot notation) and I need to set the format to something SemVer 1.0-compatible.
For example I'll gladly take something like :

$ cat GitVersion.yml
assembly-informational-versioning-scheme: NuGetVersionV2

generating

[assembly: AssemblyInformationalVersion("1.0.1-develop0009")]

@Eregrith
Copy link

Nevermind, it seems assembly-informational-format might already what I needed.. I should have searched better before posting.

@chrgei
Copy link
Author

chrgei commented Mar 4, 2017

Okay. I wanted this Format:

[assembly: AssemblyFileVersion("1.0.1.9")]

In the meantime, however, we are working according to Sem 1.0 rules.

Thank you for the response. It's a great tool.

@asbjornu
Copy link
Member

asbjornu commented Jun 22, 2017

Since #1130 seems to provide the required functionality here, I'm closing. Just reopen if something's amiss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants