Created new configuration-option assembly-file-versioning-scheme: #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has the same possible options as assembly-versioning-scheme and it is used for generating the AssamblyFileVersion just in the same matter as the AssemblyVersion. Since the AssemblyVersion is used for referencing and AssemblyLoading and AssemblyFileVersion is just a representation of the version / build of the assembly, we can now configure both independent. Default setting is MajorMinorPatch for both options.
JakeGinnivan
requested changes
Feb 25, 2017
There was a problem hiding this comment.
Looks good, two small comments (changed comment to review comment)
- None of the tests actually verify MajorMinorPatchTag, could you change an existing test or just add a new one
- It would be great to replace the tabs with spaces to be consistent. We probably should have http://editorconfig.org/ configured to prevent this issue (feel free to add)
|
I've done the requested changes. One additional test checks the configuration-option (ConfigProviderTests.CanUpdateAssemblyFileVersioningScheme()) and another test checks the result of the possible settings of AssemblyFileVersioningScheme (AssemblyFileVersionTests.ValidateAssemblyFileVersionBuilder()). |
|
All merged @jensbrand, thanks. Sorry it took so long |
This was referenced Jun 21, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created new configuration-option assembly-file-versioning-scheme: It has the same possible options as assembly-versioning-scheme and it is used for generating the AssamblyFileVersion just in the same matter as the AssemblyVersion.
Since the AssemblyVersion is used for referencing and AssemblyLoading and AssemblyFileVersion is just a representation of the version / build of the assembly, we can now configure both independent.
Default setting is MajorMinorPatch for both options.
This change is discussed in issue: #544