Skip to content

Fixes #1430 - gitreleasenotes step. #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Conversation

dazinator
Copy link
Member

Corrected path to git release notes to fix build.

Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13
Copy link
Member

gep13 commented Jun 28, 2018

@dazinator I am surprised that this addition is needed, but I suspect that it is due to changes in the way that NuGet Addins/Tools are resolved.

This changed in a recent version of Cake.

@gep13 gep13 merged commit af73f6a into GitTools:master Jun 28, 2018
@gep13
Copy link
Member

gep13 commented Jun 28, 2018

@dazinator yeah, that didn't work :-(

The correct path to the file is:

tools\GitReleaseNotes.0.7.0\tools\GitReleaseNotes.exe

@gep13
Copy link
Member

gep13 commented Jun 28, 2018

@dazinator Can I suggest using something like this:

FilePath gitReleaseNotesPath = Context.Tools.Resolve("GitReleaseNotes.exe");

Which will return:

C:/github_local/organisations/gittools/GitVersion/tools/GitReleaseNotes.0.7.0/tools/GitReleaseNotes.exe

To save having to hard code the path?

@dazinator
Copy link
Member Author

dazinator commented Jun 28, 2018

Odd - that's what the path is for me locally:

image

I'll change it to your suggestion :-)

@arturcic
Copy link
Member

arturcic commented Jun 28, 2018

@gep13
Copy link
Member

gep13 commented Jun 28, 2018

@dazinator I am going to go out on a limb and say that you have got an old version of Cake locally on your machine.

image

If you go into the tools folder and then the Cake folder and right click on the Cake.exe, what version does it say you have?

@gep13
Copy link
Member

gep13 commented Jun 28, 2018

@arturcic said...
can we use the cake addin as is? https://cakebuild.net/api/Cake.Common.Tools.GitReleaseNotes/GitReleaseNotesAliases/

That is definitely something to consider. There are actually a few places in the current build script that is using Start.Process, when there is a Cake DSL that could help.

I would suggest that as an enhancement once the main piece of work is done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants