-
Notifications
You must be signed in to change notification settings - Fork 651
Fixes #1430 - gitreleasenotes step. #1431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@dazinator I am surprised that this addition is needed, but I suspect that it is due to changes in the way that NuGet Addins/Tools are resolved. This changed in a recent version of Cake. |
@dazinator yeah, that didn't work :-( The correct path to the file is:
|
@dazinator Can I suggest using something like this:
Which will return:
To save having to hard code the path? |
can we use the cake tool as this? https://cakebuild.net/api/Cake.Common.Tools.GitReleaseNotes/GitReleaseNotesAliases/ |
@dazinator I am going to go out on a limb and say that you have got an old version of Cake locally on your machine. If you go into the tools folder and then the Cake folder and right click on the Cake.exe, what version does it say you have? |
That is definitely something to consider. There are actually a few places in the current build script that is using Start.Process, when there is a Cake DSL that could help. I would suggest that as an enhancement once the main piece of work is done here. |
Corrected path to git release notes to fix build.