-
Notifications
You must be signed in to change notification settings - Fork 651
Refactoring of merge message class #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of merge message class #1487
Conversation
I think all of the old matches make no sense, so I welcome these breaking changes. I'll wait for others to reply before merging, but this LGTM. |
@asbjornu I've pre-emptively raised #1488 which introduces the actual feature set I've been working towards. It favours If you're happy with the breaking changes, should I close this and move the breaking change info into that request? |
@Kieranties: No, we'll keep this open for a few days before merging so @GitTools/developers can have a chance to review it. If I hear nothing, I'll merge and you can rebase #1488 on |
@Kieranties: Since we've now decided to bump the major version due to other breaking changes, I would highly appreciate if you could rebase this PR and fix the merge conflicts. 🙏 |
@Kieranties: Excellent! |
Add additional tests for TFS messages
@asbjornu I see this is out of date again. I've updated my branch to chase things up. |
Thanks, @Kieranties. 🙏 |
Awesome! I'll get #1488 fixed up this evening! |
Refactoring of the
MergeMessage
class to enable simpler (and consistent) approach to adding new regular expressions. This is a prelude to an additional PR where I hope to enable custom patterns through config.This introduces the following breaking changes:
Merged Branch = feature/one
Merged Branch = feature/two
Target Branch = master
Merged Branch = feature/one into dev
Target Branch = dev
Merged Branch = feature/one
Target Branch = dev
Merged Branch = feature/two
Target Branch = null
Merged Branch = feature/two
Target Branch = master
Target Branch = master
Target Branch = master