Skip to content

Add -nonormalize option to disable normalize function #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 16, 2019

Conversation

Bankers88
Copy link
Contributor

@Bankers88 Bankers88 commented Aug 4, 2019

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@Bankers88 Bankers88 marked this pull request as ready for review August 4, 2019 11:56
@Bankers88
Copy link
Contributor Author

Does any know why the Linux build fails azure pipeline?

@arturcic
Copy link
Member

arturcic commented Aug 5, 2019

Looks like they have updated the Linux image microsoft/azure-pipelines-image-generation@ubuntu16/156.2...releases/ubuntu16/156#diff-f87405c9dd43f633a04dd078666d61afR106, they updated the mono and that's the reason

arturcic and others added 2 commits August 5, 2019 13:53
@arturcic arturcic requested a review from asbjornu August 5, 2019 12:21
@arturcic arturcic added this to the 5.1.0 milestone Aug 5, 2019
@Bankers88
Copy link
Contributor Author

Ping @asbjornu

@arturcic
Copy link
Member

I guess he's on vacation at the moment.

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the erroneous approval. This is missing documentation, isn't it?

@Bankers88
Copy link
Contributor Author

Bankers88 commented Aug 14, 2019

Sorry for the erroneous approval. This is missing documentation, isn't it?

This option is explained in the HelpWriter.cs. Or do you mean in de docs folder? If so where do you want this documentation?

@asbjornu
Copy link
Member

@Bankers88, yes in the docs folder. Sorry for not being more specific.

@Bankers88
Copy link
Contributor Author

Yet again an update of the Linux image?

@arturcic
Copy link
Member

It seems it's now related to the way some parallel jobs are scheduled, I guess they deployed a new version of the engine and that one is not working as before

@arturcic
Copy link
Member

@Bankers88, the build was fixed now, this time the Agent Name of the Azure pipeline was changed, and we rely on the name to understand if we run on azure pipelines.

@Bankers88
Copy link
Contributor Author

@asbjornu documentation is updated!

Copy link
Member

@asbjornu asbjornu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I see now that we should have a full listing of available command line switches in the documentation. That's out of scope for this PR though.

@asbjornu asbjornu merged commit f953257 into GitTools:master Aug 16, 2019
@asbjornu
Copy link
Member

Thank you so much for your contributions, @Bankers88! 🙏

@fedebn
Copy link

fedebn commented Dec 16, 2019

I'm sorry, but I havn't understand how to use the /nonormalize option in my jenkins build, i'm using a sln with GitVersionTask on all projects (sdk), and i use MSBuild from Jenkins (not pipeline).
Someone can explain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants