Skip to content

add support for custom merge messages without 'TargetBranch' capture group #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Dobriy33
Copy link
Contributor

@Dobriy33 Dobriy33 commented Oct 9, 2019

Hello. There is small issue, that doesn't allow to use GV in bitbucket cloud repositories. Bitbucket provides following merge message format for pull requests: "Merged in feature/one (pull request #N)". This message doesn't match the requirements for custom branches because doesn't contain TargetBranch

The regular expression should contain the following capture groups:
SourceBranch - Identifies the source branch of the merge
TargetBranch - Identifies the target of the merge
PullRequestNumber - Captures the pull-request number

I passed current branch name to mergeMessage processor to get it if message regex doesn't contain Target branch.
I tested it on Bitbucket project and it works good.

@asbjornu
Copy link
Member

asbjornu commented Oct 9, 2019

Can't you use the merge-message-formats introduced in #1488?

@Dobriy33
Copy link
Contributor Author

Dobriy33 commented Oct 9, 2019

Oh.. I checked code again and I see, that TargetBranch isn't used anywhere besides tests.. But configuration.md says that this capture group is required in regex..
I think we can close this PR.

@Dobriy33 Dobriy33 closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants