Skip to content

Docs: Describe configuration for using Conventional commits #2553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AlexGoris-KasparSolutions
Copy link
Contributor

This change adds a chapter to the docs which describes how to configure GitVersion for using it with conventional commits

Description

Using the *-version-bump-message configuration, I created some regex's which work for the conventional commit standard.

Related Issue

Contributing guidelines didn't mention an open issue would be needed for documentation changes, do I need one?

Motivation and Context

I've been a long time fan of this project (thanks guys! ❤), but since I started using conventional commits last year I've always struggled with keeping the configuration as simple as possible, at best this involved the use of GitVersion with several other tools chained together. This way I can finally use just a simple GitVersion.yml in my repo's and have my builds versioned accordingly.

I imagine there are others like me out there, so hopefully it will be of use to someone.

How Has This Been Tested?

I added tests which test various conventional commit scenarios I could come up with.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Base automatically changed from master to main January 31, 2021 12:46
@arturcic arturcic enabled auto-merge (rebase) February 1, 2021 11:39
@arturcic
Copy link
Member

arturcic commented Feb 1, 2021

can you rebase on top of main?

@arturcic arturcic added this to the 5.6.5 milestone Feb 1, 2021
The added tests will validate whether more complex version bump commit scenario's are processes correctly.
Also added tests to ensure this will keep working
I added this earlier but then decided to create a new test alltogether
@AlexGoris-KasparSolutions
Copy link
Contributor Author

can you rebase on top of main?

Done

@arturcic arturcic requested a review from asbjornu February 1, 2021 14:04
@asbjornu asbjornu disabled auto-merge February 1, 2021 14:09
@asbjornu asbjornu merged commit 464c7ce into GitTools:main Feb 1, 2021
@asbjornu
Copy link
Member

asbjornu commented Feb 1, 2021

Thank you so much for providing this, @AlexGoris-KasparSolutions! 🙏🏼

@github-actions
Copy link

github-actions bot commented Feb 7, 2021

🎉 This issue has been resolved in version 5.6.5 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@Fresa
Copy link

Fresa commented Mar 2, 2021

The syntax for breaking changes is incorrect.
https://www.conventionalcommits.org/en/v1.0.0/#specification

  1. If included as a footer, a breaking change MUST consist of the uppercase text BREAKING CHANGE, followed by a colon, space, and description, e.g., BREAKING CHANGE: environment variables now take precedence over config files.

Also, a body is optional.

I'm no regex(pert) (yeah I did that :P ) but I think this should solve it:
https://regex101.com/r/xQ5Mdg/3

@asbjornu
Copy link
Member

asbjornu commented Mar 2, 2021

Pull requests are welcome, @Fresa! 🙏🏼

@AlexGoris-KasparSolutions AlexGoris-KasparSolutions deleted the conventional-commits branch March 3, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] use conventionalcommits.org message information by default
4 participants