fix!: no-bump-message now takes precedence over *-version-bump-message. #3202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanplevesque
force-pushed
the
no-bump-message-priority
branch
from
522bf7c to
9baadce
Compare
asbjornu
reviewed
Sep 23, 2022
jeanplevesque
force-pushed
the
no-bump-message-priority
branch
from
9baadce to
99692fa
Compare
asbjornu
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Do you feel like this is ready for review now, @jeanplevesque?
Yep! 😀 |
|
Thank you @jeanplevesque for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behavior of
commit-message-incrementingwhen using commits that matches both*-version-bump-messageandno-bump-message.no-bump-messagenow takes precedence over*-version-bump-message.Previous Behavior
Commits that match both
*-version-bump-messageandno-bump-messageuse the highest increment associated with*-version-bump-message.New Behavior
Commits that match both
*-version-bump-messageandno-bump-messagedon't have an increment.Related Issue
Resolves #3172.
Motivation and Context
Repositories that enforce conventional commits along with
commit-message-incrementing(with a config like this) can now have commits that don't have version bumps.Example:
How Has This Been Tested?
An integration test was added to ensure the new behavior is covered by tests.
The newly added test fails when reverting the changes.
Checklist: