Don't consider "tag-prefix" as optional if it's explicitly specified #3208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@asbjornu , I've reviewed #3218 (and the corresponding PR #3224) and #3060. I agree with #3224 (comment) answer that we are talking about different tags. I think that the only reason why this change can be considered as a breaking if |
|
@AlexPykavy, yes, I think you can retarget this against |
To correctly calculate the next version with the prefix. For example, we develop the main product and some its plugin in the same repository and have the following git tags list: - 0.1.0 - 0.1.1 - 0.2.0 - 0.2.1 - plugin_0.1.0 - plugin_0.1.1 The expected next plugin version is `0.1.2` not `0.2.2` (`plugin_` prefix will be prepended before setting the tag).
Done. |
|
Thank you @AlexPykavy for your contribution! |
RatserX
added a commit
to RatserX/GitVersion
that referenced
this pull request
Nov 3, 2022
commit f76d8b8 Merge: f6d86dc 8c6175c Author: Artur <[email protected]> Date: Wed Oct 26 09:05:35 2022 +0200 Merge pull request GitTools#3246 from arturcic/feature/markdown-lint Fix docs markdown lint errors commit 8c6175c Author: Artur <[email protected]> Date: Wed Oct 26 08:40:13 2022 +0200 GitTools#2964 - disable tests for .net48 commit 21c34fb Author: Artur <[email protected]> Date: Wed Oct 26 02:07:16 2022 +0200 GitTools#2964 - use bash for reporter commit 93f4637 Author: Artur <[email protected]> Date: Tue Oct 25 23:50:45 2022 +0200 GitTools#2964 fix markdown linting errors commit 18586fe Author: Artur <[email protected]> Date: Tue Oct 25 19:21:56 2022 +0200 GitTools#2964 fix html-proofer errors commit f6d86dc Author: Artur <[email protected]> Date: Tue Oct 25 16:15:45 2022 +0200 (build) fix set-output syntax https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ commit 2cc427c Author: Artur <[email protected]> Date: Tue Oct 25 15:25:27 2022 +0200 Revert "(build) fix set-output syntax" This reverts commit b906175. commit b812802 Author: Artur <[email protected]> Date: Tue Oct 25 15:49:10 2022 +0200 Revert "(build) fix set-output syntax" This reverts commit b07a8b9. commit b07a8b9 Author: Artur <[email protected]> Date: Tue Oct 25 15:49:10 2022 +0200 (build) fix set-output syntax https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ commit b906175 Author: Artur <[email protected]> Date: Tue Oct 25 15:25:27 2022 +0200 (build) fix set-output syntax https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ commit 34f9de7 Author: Artur <[email protected]> Date: Tue Oct 25 14:08:54 2022 +0200 (build) update the actions/[email protected] commit f954025 Author: Artur <[email protected]> Date: Tue Oct 25 14:01:52 2022 +0200 (build) update the actions/[email protected] commit 819f116 Merge: 8cd3a1b cac4eb1 Author: Artur <[email protected]> Date: Tue Oct 25 13:26:41 2022 +0200 Merge pull request GitTools#3179 from chhh/feature/report-project-file-location Add local project file location to exception when parsing fails commit cac4eb1 Author: Dmitry Avtonomov <[email protected]> Date: Fri Aug 26 13:38:47 2022 -0700 Add local project file location to exception when parsing fails Helps in solutions with multiple projects, when one of csproj files becomes corrupt. User knows where to apply fixes. commit 8cd3a1b Merge: 3e5d1e7 1071e1c Author: Asbjørn Ulsberg <[email protected]> Date: Tue Oct 25 11:26:26 2022 +0200 Merge pull request GitTools#3208 from AlexPykavy/main Don't consider "tag-prefix" as optional if it's explicitly specified commit 1071e1c Author: Alexander Pykavy <[email protected]> Date: Mon Sep 26 21:12:26 2022 +0200 Don't consider "tag-prefix" as optional if it's explicitly specified To correctly calculate the next version with the prefix. For example, we develop the main product and some its plugin in the same repository and have the following git tags list: - 0.1.0 - 0.1.1 - 0.2.0 - 0.2.1 - plugin_0.1.0 - plugin_0.1.1 The expected next plugin version is `0.1.2` not `0.2.2` (`plugin_` prefix will be prepended before setting the tag).
RatserX
added a commit
to RatserX/GitVersion
that referenced
this pull request
Nov 3, 2022
commit f76d8b8 Merge: f6d86dc 8c6175c Author: Artur <[email protected]> Date: Wed Oct 26 09:05:35 2022 +0200 Merge pull request GitTools#3246 from arturcic/feature/markdown-lint Fix docs markdown lint errors commit 8c6175c Author: Artur <[email protected]> Date: Wed Oct 26 08:40:13 2022 +0200 GitTools#2964 - disable tests for .net48 commit 21c34fb Author: Artur <[email protected]> Date: Wed Oct 26 02:07:16 2022 +0200 GitTools#2964 - use bash for reporter commit 93f4637 Author: Artur <[email protected]> Date: Tue Oct 25 23:50:45 2022 +0200 GitTools#2964 fix markdown linting errors commit 18586fe Author: Artur <[email protected]> Date: Tue Oct 25 19:21:56 2022 +0200 GitTools#2964 fix html-proofer errors commit f6d86dc Author: Artur <[email protected]> Date: Tue Oct 25 16:15:45 2022 +0200 (build) fix set-output syntax https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ commit 2cc427c Author: Artur <[email protected]> Date: Tue Oct 25 15:25:27 2022 +0200 Revert "(build) fix set-output syntax" This reverts commit b906175. commit b812802 Author: Artur <[email protected]> Date: Tue Oct 25 15:49:10 2022 +0200 Revert "(build) fix set-output syntax" This reverts commit b07a8b9. commit b07a8b9 Author: Artur <[email protected]> Date: Tue Oct 25 15:49:10 2022 +0200 (build) fix set-output syntax https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ commit b906175 Author: Artur <[email protected]> Date: Tue Oct 25 15:25:27 2022 +0200 (build) fix set-output syntax https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ commit 34f9de7 Author: Artur <[email protected]> Date: Tue Oct 25 14:08:54 2022 +0200 (build) update the actions/[email protected] commit f954025 Author: Artur <[email protected]> Date: Tue Oct 25 14:01:52 2022 +0200 (build) update the actions/[email protected] commit 819f116 Merge: 8cd3a1b cac4eb1 Author: Artur <[email protected]> Date: Tue Oct 25 13:26:41 2022 +0200 Merge pull request GitTools#3179 from chhh/feature/report-project-file-location Add local project file location to exception when parsing fails commit cac4eb1 Author: Dmitry Avtonomov <[email protected]> Date: Fri Aug 26 13:38:47 2022 -0700 Add local project file location to exception when parsing fails Helps in solutions with multiple projects, when one of csproj files becomes corrupt. User knows where to apply fixes. commit 8cd3a1b Merge: 3e5d1e7 1071e1c Author: Asbjørn Ulsberg <[email protected]> Date: Tue Oct 25 11:26:26 2022 +0200 Merge pull request GitTools#3208 from AlexPykavy/main Don't consider "tag-prefix" as optional if it's explicitly specified commit 1071e1c Author: Alexander Pykavy <[email protected]> Date: Mon Sep 26 21:12:26 2022 +0200 Don't consider "tag-prefix" as optional if it's explicitly specified To correctly calculate the next version with the prefix. For example, we develop the main product and some its plugin in the same repository and have the following git tags list: - 0.1.0 - 0.1.1 - 0.2.0 - 0.2.1 - plugin_0.1.0 - plugin_0.1.1 The expected next plugin version is `0.1.2` not `0.2.2` (`plugin_` prefix will be prepended before setting the tag).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To correctly calculate the next version with the prefix.
For example, we develop the main product and some its plugin in the same repository and have the following git tags list:
The expected next plugin version is
0.1.2not0.2.2(plugin_prefix will be prepended before setting the tag).Related Issue
Resolves #3216.
Motivation and Context
Makes possible to have 2 independent versioning sequences in the same repository.
How Has This Been Tested?
Unit test case is added.
Screenshots (if appropriate):
Checklist: