-
Notifications
You must be signed in to change notification settings - Fork 654
Rename back "tag-pre-release-weight" and "tag-prefix" #3481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename back "tag-pre-release-weight" and "tag-prefix" #3481
Conversation
@ni-jsuchocki please run these scripts |
Hmm I'm on Mac and I'm having hard time making the script work (managing various versions of dotnet on Mac is a mess). I have powershell installed and I ran the first command successfully, but when I run
Any idea what causes this? The gitversion binary I have installed is 6.0.0:
|
|
Ok thanks, that was it. For now I uploaded it as a separate commit, should I squash them before merging in the changes from main? |
I would say squash them |
d56fbd3
to
2796f0c
Compare
@ni-jsuchocki can you please rebase your changes on |
2796f0c
to
08a4b5c
Compare
src/GitVersion.Core.Tests/IntegrationTests/VersionInTagScenarios.cs
Outdated
Show resolved
Hide resolved
src/GitVersion.Core.Tests/IntegrationTests/VersionInTagScenarios.cs
Outdated
Show resolved
Hide resolved
@ni-jsuchocki can you check the comments? |
Sure sure, noticed that right after I rebased. |
08a4b5c
to
921d024
Compare
Thank you @ni-jsuchocki for your contribution! |
Description
Renamed
label-pre-release-weight => tag-pre-release-weight
label-prefix => tag-prefix
Related Issue
Fixes #3480