-
Notifications
You must be signed in to change notification settings - Fork 651
Add tests for GitLab CI to ignore branch name for tags #4402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for GitLab CI to ignore branch name for tags #4402
Conversation
In case of a tag pipeline, return null as branch name instead of the tag
@Bi0T1N can you actually push these changes to that PR instead? |
How would I do that? I guess I'd need write permissions in the fork from AlphaYankee. |
it really depends if he put any branch restrictions on his fork, you just add his fork as another origin and push to his branch. Another option would be instead of pushing to his branch (if there are set restrictions) you can integrate his changes into your PR (your rebase your branch on top of his), so his commits are first added and yours are on top of his changes, this way you keep his original work and yours |
02f2a47
to
5f0d4e7
Compare
I added the changes from AlphaYankee to my branch |
5f0d4e7
to
e4cf434
Compare
Thank you @Bi0T1N for your contribution! |
🎉 This issue has been resolved in version 6.2.0 🎉 Your GitReleaseManager bot 📦🚀 |
Description
This PR adds the missing tests for PR #4187. That PR needs to be merged first since without the changes you'll see two errors:
Related Issue
#4186
Motivation and Context
This pull request should help to get PR #4187 merged! With the changes from @AlphaYankee all tests succeed.
How Has This Been Tested?
To verify the behavior of the GitLab CI I created a test project that can be found here with all the relevant
CI_*
variables in the job log output.This demonstrates how the tagging works in GitLab (
CI_COMMIT_TAG
available only in pipelines for tags):main
branch (notice thatCI_COMMIT_TAG
isn't set)Checklist: