-
Notifications
You must be signed in to change notification settings - Fork 651
Conditional ms build tasks #687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<UpdateAssemblyInfo | ||
SolutionDirectory="$(SolutionDir)" | ||
NoFetch="$(GitVersion_NoFetchEnabled)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you removed NoFetch intentionally? This was introduced to fix #646
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No - it's a diff I didn't catch when creating a patch from my "messy" repo.
Added NoFetch back (and if someone wonder, I am not going to touch git -rebase to make this any "prettier" ;) |
LGTM. The only thing I'm not sure is, that with now three individual targets, all dependent on the same target, is it ensured that they are always called in the correct order? |
I didn't think there was a dependency between this targets, if so this PR breaks up. The intention was to switch of the tasks you didn't want (UpdateAssemblyInfo in my case, because I want to handle AssemblyVersion, AssemblyFileVersion and AssemblyInformationalVersion individually, and so far I haven't had any problems with it). This solution only assure that the tasks are run before CoreCompile, in no particular order. If there is a dependency between them, I can't switch them off at will. Do you have any further information about this? |
@JakeGinnivan Do you know if the execution order is an issue here? |
Not sure.. @SimonCropp ? |
…fault values of SolutionDir and IntermediateOutputPatch)
The original order was; WriteVersionInfoToBuildLog, UpdateAssemblyInfo and GetVersion. WriteVersionInfoToBuildLog cant be dependent on any of the other task. The remaining questions then are - is UpdateAssemblyInfo dependent on WriteVersionInfoToBuild Log, would running WriteVersionInfoToBuildLog after the other tasks create havoc? |
This is an area of GitVersion I don't know very well so it all looks fine to me. @pascalberger if you can't see anything, lets merge |
Conditional ms build tasks
Did a retake on this pull request - allows the user to conditionally disable GitVersions MSBuild tasks
Default behavior is to run all task (as before)