Feature/task disk cache #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cache entries are placed in .git\gitversion_cache\ directory.
…ke testing easier.
… to make testing easier.
…us and quite possibly enjoyable task.
…ersion cache file.
… it's easier and more consistent to exclude properties that aren't version variables.
…e` property and make use of it in `VersionAndBranchFinderLoadVersionVariablesFromDiskCache()`.
…ernal and internals visible to GitVersionTask.Tests so we can reset the in-memory cache for testing. Not very elegant, but that's `static` for you. :-/
…m work, since AppVeyor don't seem to agree with local test running in that everything is green. Not trying to fake it may be a better solution anyhow. Ref https://ci.appveyor.com/project/GitTools/gitversion/build/3.3.1-PullRequest.711+28%20(Build%20458)
…ith `Repository.Discover()`.
…rs in `SetLoggers()`.
…teCore` and replaced all usage of the former with the latter. Also made `ExecuteCore` non-static.
JakeGinnivan
force-pushed
the
feature/task-disk-cache
branch
from
a2e3ddf to
d7a6402
Compare
- No more in memory cache - Pulled all caching code out to it's own class - Only open repo once - Moved open repo into execute core
|
@asbjornu I have rebased, made some further refactorings/cleanups and got the build green :) Nice change, I ended up removing the in memory cache. Would love a follow up review just to make sure I have not messed something up. |
|
Superseeds #711 |
|
Gonna merge this now @asbjornu, if you see issues, lets fix them in another PR |
|
@JakeGinnivan Thanks! I don't notice anything, but if I do, I'll make another PR. Glad to finally see this merged. It will speed up our builds considerably. :) |
|
I haven't got the release together yet, will do soon |
|
@JakeGinnivan No rush. Looking forward to trying it out. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.