Fix to stop GitVersion from introducing the remote name into branch name #911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdbehrho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using GitVersion on a Jenkins build server, the remote name was getting introduced into the branch name when NormalizeGitDirectory was called. I found this to be happening because in the Jenkins GetCurrentBranch method, it was getting the environment variable "GIT_BRANCH" which would be something like "origin/master". There is now a variable available in Git called "GIT_LOCAL_BRANCH" that would just return "master" without the remote name, so I changed Jenkins.cs to use that variable instead unless it is not defined. I also added a simple test to EnvironmentVariableJenkinsTests.cs
Fixes #857