modify cache key calc to use entire contents of .git/refs instead of timestamp #969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy cache factory to traverse refs directory instead of just looking at the timestamp (which changes if renormalized)
tofutim
changed the title
| } | ||
|
|
||
| // lifted from https://msdn.microsoft.com/en-us/library/bb513869.aspx | ||
| public static List<string> TraverseTree(string root) |
There was a problem hiding this comment.
No
On Jul 24, 2016, at 11:07, Asbjørn Ulsberg [email protected] wrote:
In src/GitVersionCore/GitVersionCacheKeyFactory.cs:
return GetHash(dotGitDirectory, lastGitRefsChangedTicks.ToString());return GetHash(traverse.ToArray());}
// lifted from https://msdn.microsoft.com/en-us/library/bb513869.aspxpublic static List<string> TraverseTree(string root)—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
There was a problem hiding this comment.
Rename to what it actually does, ex. CalculateDirectoryContents.
|
How heavy is this? Could we just hash the refs instead as well as HEAD. |
| var targetUrl = "https://github.com/GitTools/GitVersion.git"; | ||
| var targetBranch = "refs/head/master"; | ||
| var gitPreparer = new GitPreparer(targetUrl, null, new Authentication(), false, fixture.RepositoryPath); | ||
| //var cacheKey0 = GitVersionCacheKeyFactory.Create(fileSystem, gitPreparer, null); |
There was a problem hiding this comment.
Remove this line instead of commenting.
There was a problem hiding this comment.
I left it there as a reminder that the cache key changes after Initialize, but ok.
|
@JakeGinnivan This checks the files and directories in refs only. On my TeamCity (with a bit more logging than in this PR): 22ms for the first run. Afterwards the data is cached by the filesystem or so, and it takes 8ms. Locally: 62ms (first run), afterwards 22ms. |
|
Thanks @DanielRose, should have looked closer. I thought was more than just refs :P |
|
We're going to introduce GitVersion and our first ci build (with GitLab CI) took about 47 minutes. Using this PR, the total time reduces to 2.5 minutes. I think this solves the problem. |
| { | ||
| files = Directory.GetFiles(currentDir); | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove these empty lines (line 93 as well).
|
I've fixed up the style issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't see the note in rebase that the range is excluding the first one - so it took me a while to figure out how to do it. Ref: #967 (original pull request) - should resolve #942